Bootstrap: Add testsuite for compiletest tool #56792

phansch · 2018-12-13T21:13:09Z

This adds a test suite for compiletest so that the tester is tested, too.

The (currently) single unit test of the compiletest tool was never executed
on CI. At least I couldn't find any references of it in the logs.

The compiletest tests can then also be executed with:

./x.py test src/tools/compiletest --stage 0

cc #47606

rust-highfive · 2018-12-13T21:13:19Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

phansch · 2018-12-13T21:16:03Z

NB: I'm not 100% sure why 9884cf8 is required. Without it, running the compiletest tests failed with:

error[E0308]: mismatched types                                                       
   --> src/tools/compiletest/src/main.rs:519:22                 
    |                                                                                                            
519 |         run_ignored: config.run_ignored,                                           
    |                      ^^^^^^^^^^^^^^^^^^ expected enum `test::RunIgnored`, found bool
    |                                                                                                             
    = note: expected type `test::RunIgnored`                                                      
               found type `bool`

This is probably related to #55053

rust-highfive · 2018-12-13T22:10:32Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0983ed49:start=1544735713985737174,finish=1544735790734406241,duration=76748669067
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

phansch · 2018-12-14T07:25:14Z

It looks like ./x.py build src/tools/compiletest now fails because it doesn't know about RunIgnored. It's probably a mistake somewhere in the Compiletest step implementation? I will get back to it later today.

alexcrichton · 2018-12-14T17:48:52Z

src/bootstrap/test.rs

+        let host = self.host;
+        let compiler = builder.compiler(stage, host);
+
+            let mut cargo = tool::prepare_tool_cargo(builder,


The indentation here looks like it may be off?

The (currently) single unit test of the compiletest tool was never executed on CI. At least I couldn't find any references of it in the logs. This adds a test suite for compiletest so that our tester is tested, too. The compiletest tests can then also be executed with: ./x.py test src/tools/compiletest

phansch · 2018-12-14T21:33:33Z

It looks like #56536 fixed the compiletest build issue 👍

alexcrichton · 2018-12-14T22:20:40Z

@bors: r+

bors · 2018-12-14T22:20:41Z

📌 Commit c435357 has been approved by alexcrichton

alexcrichton · 2018-12-14T22:20:52Z

@bors: rollup

…r=alexcrichton Bootstrap: Add testsuite for compiletest tool This adds a test suite for compiletest so that the tester is tested, too. The (currently) single unit test of the compiletest tool was never executed on CI. At least I couldn't find any references of it in the logs. The compiletest tests can then also be executed with: ./x.py test src/tools/compiletest --stage 0 cc rust-lang#47606

@ghost

Rollup of 14 pull requests Successful merges: - #56718 (Use libbacktrace pretty-printing) - #56725 (fix rust-lang/rust issue #50583) - #56731 (Add missing urls in ffi module docs) - #56738 (Fix private_no_mangle_fns message grammar) - #56746 (Add test of current behavior (infer free region within closure body)) - #56747 (target: remove Box returned by get_targets) - #56751 (Allow ptr::hash to accept fat pointers) - #56755 (Account for `impl Trait` when suggesting lifetime) - #56758 (Add short emoji status to toolstate updates) - #56760 (Deduplicate unsatisfied trait bounds) - #56769 (Add x86_64-unknown-uefi target) - #56792 (Bootstrap: Add testsuite for compiletest tool) - #56808 (Fixes broken links) - #56809 (Fix docs path to PermissionsExt) Failed merges: r? @ghost

…ttests, r=oli-obk Add some unit tests to compiletest Based on rust-lang#56792, otherwise the tests won't be executed on CI. Just a small start, I would like to add more testing to compiletest in the future but that will require some refactoring first. cc rust-lang#47606

I was assuming that rust-lang#56792 would have resulted in compiletest tests being executed in CI. However, I couldn't find any mentions of the unit test names in any CI logs. This adds the compiletest test execution to the checktools.sh script.

…, r=kennytm Actually run compiletest tests on CI I was assuming that rust-lang#56792 would have resulted in compiletest tests being executed on CI. However, I couldn't find any mentions of the unit test names in any CI logs. This adds the compiletest test execution to the checktools.sh script.

rust-highfive assigned alexcrichton Dec 13, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2018

phansch mentioned this pull request Dec 13, 2018

Add unit tests for parse_normalization_string Manishearth/compiletest-rs#143

Closed

alexcrichton reviewed Dec 14, 2018

View reviewed changes

phansch force-pushed the add_compiletest_testsuite branch from 9884cf8 to c435357 Compare December 14, 2018 20:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2018

pietroalbini mentioned this pull request Dec 15, 2018

Rollup of 14 pull requests #56840

Merged

phansch mentioned this pull request Dec 15, 2018

Add some unit tests to compiletest #56841

Merged

bors merged commit c435357 into rust-lang:master Dec 15, 2018

phansch deleted the add_compiletest_testsuite branch December 15, 2018 14:09

phansch mentioned this pull request Dec 20, 2018

Actually run compiletest tests on CI #57010

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bootstrap: Add testsuite for compiletest tool #56792

Bootstrap: Add testsuite for compiletest tool #56792

phansch commented Dec 13, 2018 •

edited

Loading

rust-highfive commented Dec 13, 2018

phansch commented Dec 13, 2018

rust-highfive commented Dec 13, 2018

phansch commented Dec 14, 2018 •

edited

Loading

alexcrichton Dec 14, 2018

phansch commented Dec 14, 2018

alexcrichton commented Dec 14, 2018

bors commented Dec 14, 2018

alexcrichton commented Dec 14, 2018

Bootstrap: Add testsuite for compiletest tool #56792

Bootstrap: Add testsuite for compiletest tool #56792

Conversation

phansch commented Dec 13, 2018 • edited Loading

rust-highfive commented Dec 13, 2018

phansch commented Dec 13, 2018

rust-highfive commented Dec 13, 2018

phansch commented Dec 14, 2018 • edited Loading

alexcrichton Dec 14, 2018

Choose a reason for hiding this comment

phansch commented Dec 14, 2018

alexcrichton commented Dec 14, 2018

bors commented Dec 14, 2018

alexcrichton commented Dec 14, 2018

phansch commented Dec 13, 2018 •

edited

Loading

phansch commented Dec 14, 2018 •

edited

Loading