Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_c_str should call the AllocationExtra hooks #56210

Merged
merged 4 commits into from
Nov 25, 2018
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 25, 2018

I just hope we do not have other methods that bypass get_bytes/get_bytes_mut... (looking over the file, I could not find any)

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Nov 25, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2018

📌 Commit 0fac350 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2018
@RalfJung
Copy link
Member Author

@oli-obk found a bug and fixed it, could you review the latest commit as well?

src/librustc/mir/interpret/allocation.rs Outdated Show resolved Hide resolved
Co-Authored-By: RalfJung <post@ralfj.de>
@oli-obk
Copy link
Contributor

oli-obk commented Nov 25, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2018

📌 Commit 2472e83 has been approved by oli-obk

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 25, 2018
read_c_str should call the AllocationExtra hooks

I just hope we do not have other methods that bypass `get_bytes`/`get_bytes_mut`... (looking over the file, I could not find any)

r? @oli-obk
bors added a commit that referenced this pull request Nov 25, 2018
Rollup of 14 pull requests

Successful merges:

 - #56024 (Don't auto-inline const functions)
 - #56045 (Check arg/ret sizedness at ExprKind::Path)
 - #56072 (Stabilize macro_literal_matcher)
 - #56075 (Encode a custom "producers" section in wasm files)
 - #56100 (generator fields are not necessarily initialized)
 - #56101 (Incorporate `dyn` into more comments and docs.)
 - #56144 (Fix BTreeSet and BTreeMap gdb pretty-printers)
 - #56151 (Move a flaky process test out of libstd)
 - #56170 (Fix self profiler ICE on Windows)
 - #56176 (Panic setup msg)
 - #56204 (Suggest correct enum variant on typo)
 - #56207 (Stabilize the int_to_from_bytes feature)
 - #56210 (read_c_str should call the AllocationExtra hooks)
 - #56211 ([master] Forward-ports from beta)

Failed merges:

r? @ghost
@bors bors merged commit 2472e83 into rust-lang:master Nov 25, 2018
@RalfJung RalfJung deleted the c_str branch November 30, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants