Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NodeId and HirLocalId newtype_index #55750

Merged
merged 7 commits into from
Nov 15, 2018
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 7, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:108f5240:start=1541592975447476803,finish=1541592976443542668,duration=996065865
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:37:33]    Compiling parking_lot_core v0.3.0
[00:37:33]    Compiling tempfile v3.0.3
[00:37:35]    Compiling parking_lot v0.6.4
[00:37:36]    Compiling rustdoc v0.0.0 (/checkout/src/librustdoc)
[00:37:41] error[E0599]: no function or associated item named `new` found for type `syntax::ast::NodeId` in the current scope
[00:37:41]     |
[00:37:41] 246 |                 NodeId::new(0),
[00:37:41] 246 |                 NodeId::new(0),
[00:37:41]     |                 ^^^^^^^^^^^ function or associated item not found in `syntax::ast::NodeId`
[00:37:41]     = help: items from traits can only be used if the trait is in scope
[00:37:41]     = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
[00:37:41]             `use rustc_data_structures::indexed_vec::Idx;`
[00:37:41] 
[00:37:41] 
[00:37:41] error[E0599]: no function or associated item named `new` found for type `syntax::ast::NodeId` in the current scope
[00:37:41]     |
[00:37:41]     |
[00:37:41] 284 |                     if item_node_id.unwrap() != NodeId::new(0) {
[00:37:41]     |                                                 ^^^^^^^^^^^ function or associated item not found in `syntax::ast::NodeId`
[00:37:41]     = help: items from traits can only be used if the trait is in scope
[00:37:41]     = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
[00:37:41]             `use rustc_data_structures::indexed_vec::Idx;`
[00:37:41] 
[00:37:41] 
[00:37:41] error[E0599]: no function or associated item named `new` found for type `syntax::ast::NodeId` in the current scope
[00:37:41]     |
[00:37:41]     |
[00:37:41] 291 |                         Some(parent) if parent != NodeId::new(0) => {
[00:37:41]     |                                                   ^^^^^^^^^^^ function or associated item not found in `syntax::ast::NodeId`
[00:37:41]     = help: items from traits can only be used if the trait is in scope
[00:37:41]     = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
[00:37:41]             `use rustc_data_structures::indexed_vec::Idx;`
[00:37:41] 
[00:37:41] 
[00:37:41]            ^^^^^^^^^^^ function or associated item not found in `syntax::ast::NodeId`
[00:37:41]     = help: items from traits can only be used if the trait is in scope
[00:37:41]     = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
[00:37:41]             `use rustc_data_structures::indexed_vec::Idx;`
[00:37:41] 
[00:37:41] 
[00:37:41] error[E0599]: no function or associated item named `new` found for type `syntax::ast::NodeId` in the current scope
[00:37:41]     |
[00:37:41] 567 |                                      NodeId::new(0),
[00:37:41] 567 |                                      NodeId::new(0),
[00:37:41]     |                                      ^^^^^^^^^^^ function or associated item not found in `syntax::ast::NodeId`
[00:37:41]     = help: items from traits can only be used if the trait is in scope
[00:37:41]     = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
[00:37:41]             `use rustc_data_structures::indexed_vec::Idx;`
3500600 .
---
151412 ./src/tools/clang
150256 ./obj/build/bootstrap/debug/incremental
149116 ./src/llvm-emscripten/test
134668 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u
134664 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u/s-f6g644o9i5-1jgvkpy-22tmsi8iacpi9
120932 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu
120928 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release
118732 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps
111096 ./src/llvm/test/CodeGen

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb
Copy link
Member

eddyb commented Nov 7, 2018

cc @nikomatsakis

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:01ec3f25:start=1541670380935691582,finish=1541670443435476600,duration=62499785018
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:52:02] .................................................................................................... 100/4999
[00:52:05] .................................................................................................... 200/4999
[00:52:08] ........................................................................ii...................ii..... 300/4999
[00:52:11] ...........................................................................................iii...... 400/4999
[00:52:14] ..iiiiiiii.iii...........................iii...........................................i...........i 500/4999
[00:52:21] .................................................................................................... 700/4999
[00:52:27] .....................................................................i...........i.................. 800/4999
[00:52:31] ........................................................................................iiiii....... 900/4999
[00:52:34] ...........ii.iiii.................................................................................. 1000/4999
---
[00:53:12] .................................................................................................... 2200/4999
[00:53:16] .................................................................................................... 2300/4999
[00:53:20] .................................................................................................... 2400/4999
[00:53:24] .................................................................................................... 2500/4999
[00:53:27] ...................................................................iiiiiiiii........................ 2600/4999
[00:53:34] ...............................ii................................................................... 2800/4999
[00:53:37] .................................................................................................... 2900/4999
[00:53:41] .................................................................................................... 3000/4999
[00:53:44] ..........................i......................................................................... 3100/4999
---
travis_time:start:test_mir-opt
Check compiletest suite=mir-opt mode=mir-opt (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:07:24] 
[01:07:24] running 45 tests
[01:07:28] ERROR 2018-11-08T10:55:02Z: compiletest::runtest: None
[01:07:28] ERROR 2018-11-08T10:55:02Z: compiletest::runtest: None
[01:07:28] ERROR 2018-11-08T10:55:02Z: compiletest::runtest: None
[01:07:30] ERROR 2018-11-08T10:55:03Z: compiletest::runtest: None
[01:07:45] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:503:22
[01:07:45] .............FFF..F..F.F..............F......
[01:07:45] 
[01:07:45] ---- [mir-opt] mir-opt/end_region_5.rs stdout ----
[01:07:45] ---- [mir-opt] mir-opt/end_region_5.rs stdout ----
[01:07:45] thread '[mir-opt] mir-opt/end_region_5.rs' panicked at 'Did not find expected line, error: Mismatch in lines
[01:07:45] Current block: None
[01:07:45] Actual Line: "    let mut _3: [closure@28 d:&\'18s D];"
[01:07:45] Expected Line: "    let mut _3: [closure@NodeId(28) d:&\'18s D];"
[01:07:45] Test Name: rustc.main.SimplifyCfg-qualify-consts.after.mir
[01:07:45] ... (elided)
[01:07:45] fn main() -> () {
[01:07:45] ... (elided)
[01:07:45] ... (elided)
[01:07:45]     let mut _0: ();
[01:07:45] ... (elided)
[01:07:45]     let _1: D;
[01:07:45] ... (elided)
[01:07:45]     let mut _2: ();
[01:07:45]     let mut _3: [closure@NodeId(28) d:&'18s D];
[01:07:45]     let mut _4: &'18s D;
[01:07:45]     bb0: {
[01:07:45]         StorageLive(_1);
[01:07:45]         _1 = D(const 0i32,);
[01:07:45]         FakeRead(ForLet, _1);
[01:07:45]         StorageLive(_3);
[01:07:45]     }
[01:07:45]     bb2: {
[01:07:45]     bb2: {
[01:07:45]         drop(_3) -> [return: bb5, unwind: bb3];
[01:07:45]     bb3: {
[01:07:45]         drop(_1) -> bb1;
[01:07:45]     }
[01:07:45]     bb4: {
[01:07:45]     bb4: {
[01:07:45]         drop(_3) -> bb3;
[01:07:45]     }
[01:07:45]     bb5: {
[01:07:45]         StorageDead(_3);
[01:07:45]         _0 = ();
[01:07:45]         drop(_1) -> [return: bb6, unwind: bb1];
[01:07:45]     bb6: {
[01:07:45]     bb6: {
[01:07:45]         StorageDead(_1);
[01:07:45]         return;
[01:07:45] }
[01:07:45] Actual:
[01:07:45] fn main() -> (){
[01:07:45] fn main() -> (){
[01:07:45]     let mut _0: ();
[01:07:45]     scope 1 {
[01:07:45]     scope 2 {
[01:07:45]         let _1: D;
[01:07:45]     }
[01:07:45]     }
[01:07:45]     let mut _2: ();
[01:07:45]     let mut _3: [closure@33 d:D];
[01:07:45]     bb0: {                              
[01:07:45]         StorageLive(_1);
[01:07:45]         _1 = D(const 0i32,);
[01:07:45]         FakeRead(ForLet, _1);
[01:07:45]         StorageLive(_3);
[01:07:45]         _3 = [closure@33] { d: move _1 };
[01:07:45]         _2 = const foo(move _3) -> [return: bb2, unwind: bb4];
[01:07:45]     bb1: {
[01:07:45]         resume;
[01:07:45]     }
[01:07:45]     }
[01:07:45]     bb2: {                              
[01:07:45]         drop(_3) -> [return: bb5, unwind: bb3];
[01:07:45]     bb3: {
[01:07:45]         drop(_1) -> bb1;
[01:07:45]     }
[01:07:45]     bb4: {
[01:07:45]     bb4: {
[01:07:45]         drop(_3) -> bb3;
[01:07:45]     }
[01:07:45]     bb5: {                              
[01:07:45]         StorageDead(_3);
[01:07:45]         _0 = ();
[01:07:45]         drop(_1) -> [return: bb6, unwind: bb1];
[01:07:45]     }
[01:07:45]     bb6: {                              
[01:07:45]         StorageDead(_1);
[01:07:45]         return;
[01:07:45] }', tools/compiletest/src/runtest.rs:2939:13
[01:07:45] 
[01:07:45] ---- [mir-opt] mir-opt/end_region_6.rs stdout ----
[01:07:45] ---- [mir-opt] mir-opt/end_region_6.rs stdout ----
[01:07:45] thread '[mir-opt] mir-opt/end_region_6.rs' panicked at 'Did not find expected line, error: Mismatch in lines
[01:07:45] Current block: None
[01:07:45] Actual Line: "    let mut _3: [closure@33 d:&\'24s D];"
[01:07:45] Expected Line: "    let mut _3: [closure@NodeId(33) d:&\'24s D];"
[01:07:45] Test Name: rustc.main.SimplifyCfg-qualify-consts.after.mir
[01:07:45] ... (elided)
[01:07:45] fn main() -> () {
[01:07:45] fn main() -> () {
[01:07:45]     let mut _0: ();
[01:07:45] ... (elided)
[01:07:45]     let _1: D;
[01:07:45] ... (elided)
[01:07:45]     let mut _2: ();
[01:07:45]     let mut _3: [closure@NodeId(33) d:&'24s D];
[01:07:45]     let mut _4: &'24s D;
[01:07:45]     bb0: {
[01:07:45]         StorageLive(_1);
[01:07:45]         _1 = D(const 0i32,);
[01:07:45]         FakeRead(ForLet, _1);
[01:07:45]         StorageLive(_3);
[01:07:45]         StorageLive(_4);
[01:07:45]         _4 = &'24s _1;
[01:07:45]         _3 = [closure@NodeId(33)] { d: move _4 };
[01:07:45]         StorageDead(_4);
[01:07:45]         _2 = const foo(move _3) -> [return: bb2, unwind: bb3];
[01:07:45]     bb1: {
[01:07:45]         resume;
[01:07:45]     }
[01:07:45]     bb2: {
[01:07:45]     bb2: {
[01:07:45]         EndRegion('24s);
[01:07:45]         StorageDe: {
[01:07:45]        EndRegion('24s);
[01:07:45]        EndRegion('26_1rs);
[01:07:45]        drop(_1) -> bb1;
[01:07:45]    bb4: {
[01:07:45]    bb4: {
[01:07:45]        StorageDead(_1);
[01:07:45]        return;
[01:07:45] }
[01:07:45] Actual:
[01:07:45] fn main() -> (){
[01:07:45] fn main() -> (){
[01:07:45]     let mut _0: ();
[01:07:45]     scope 1 {
[01:07:45]         scope 3 {
[01:07:45]         scope 4 {
[01:07:45]         scope 4 {
[01:07:45]             let _2: &'26_1rs D;
[01:07:45]     }
[01:07:45]     scope 2 {
[01:07:45]         let _1: D;
[01:07:45]     }
[01:07:45]     }
[01:07:45]     let mut _3: ();
[01:07:45]     let mut _4: [closure@33 r:&'24s D];
[01:07:45]     bb0: {                              
[01:07:45]         StorageLive(_1);
[01:07:45]         _1 = D(const 0i32,);
[01:07:45]         FakeRead(ForLet, _1);
[01:07:45]         StorageLive(_2);
[01:07:45]         _2 = &'26_1rs _1;
[01:07:45]         FakeRead(ForLet, _2);
[01:07:45]         StorageLive(_4);
[01:07:45]         _4 = [closure@33] { r: _2 };
[01:07:45]         _3 = const foo(move _4) -> [return: bb2, unwind: bb3];
[01:07:45]     bb1: {
[01:07:45]         resume;
[01:07:45]     }
[01:07:45]     }
[01:07:45]     bb2: {                              
[01:07:45]         EndRegion('24s);
[01:07:45]         StorageDead(_4);
[01:07:45]         _0 = ();
[01:07:45]         EndRegion('26_1rs);
[01:07:45]         StorageDead(_2);
[01:07:45]         drop(_1) -> [return: bb4, unwind: bb1];
[01:07:45]     bb3: {
[01:07:45]     bb3: {
[01:07:45]         EndRegion('24s);
[01:07:45]         EndRegion('26_1rs);
[01:07:45]         drop(_1) -> bb1;
[01:07:45]     }
[01:07:45]     bb4: {                              
[01:07:45]         StorageDead(_1);
[01:07:45]         return;
[01:07:45] }', tools/compiletest/src/runtest.rs:2939:13
[01:07:45] 
[01:07:45] ---- [mir-opt] mir-opt/inline-closure-borrows-arg.rs stdout ----
[01:07:45] ---- [mir-opt] mir-opt/inline-closure-borrows-arg.rs stdout ----
[01:07:45] thread '[mir-opt] mir-opt/inline-closure-borrows-arg.rs' panicked at 'Did not find expected line, error: ran out of mir dump to match against
[01:07:45] Expected Line: "    _3 = [closure@NodeId(53)];"
[01:07:45] Test Name: rustc.foo.Inline.after.mir
[01:07:45] ... (elided)
[01:07:45] ... (elided)
[01:07:45] bb0: {
[01:07:45] ... (elided)
[01:07:45] ... (elided)
[01:07:45]     _3 = [closure@NodeId(53)];
[01:07:45] ... (elided)
[01:07:45]     _4 = &_3;
[01:07:45] ... (elided)
[01:07:45]     _6 = &(*_2);
[01:07:45] ... (elided)
[01:07:45]     _7 = &(*_2);
[01:07:45]     _5 = (move _6, move _7);
[01:07:45]     _8 = move (_5.0: &i32);
[01:07:45]     _9 = move (_5.1: &i32);
[01:07:45] ... (elided)
[01:07:45]     _0 = (*_8);
[01:07:45] ... (elided)
[01:07:45]     return;
[01:07:45] }
[01:07:45] ... (elided)
[01:07:45] Actual:
[01:07:45] fn foo(_1: T, _2: &i32) -> i32{
[01:07:45]     let mut _0: i32;
[01:07:45]     scope 1 {
[01:07:45]         scope 3 {
[01:07:45]     }
[01:07:45]     scope 2 {
[01:07:45]     scope 2 {
[01:07:45]         let _3: [closure@53];
[01:07:45]     scope 4 {
[01:07:45]     }
[01:07:45]     scope 5 {
[01:07:45]     }
[01:07:45]     }
[01:07:45]     let mut _4: &[closure@53];
[01:07:45]     let mut _5: (&i32, &i32);
[01:07:45]     let mut _6: &i32;
[01:07:45]     let mut _7: &i32;
[01:07:45]     let mut _8: &i32;
[01:07:45]     let mut _9: &i32;
[01:07:45]     bb0: {                              
[01:07:45]         StorageLive(_3);
[01:07:45]         _3 = [closure@53];
[01:07:45]         StorageLive(_4);
[01:07:45]         _4 = &_3;
[01:07:45]         StorageLive(_5);
[01:07:45]         StorageLive(_6);
[01:07:45]         _6 = &(*_2);
[01:07:45]         StorageLive(_7);
[01:07:45]         _7 = &(*_2);
[01:07:45]         _5 = (move _6, move _7);
[01:07:45]         _8 = move (_5.0: &i32);
[01:07:45]         _9 = move (_5.1: &i32);
[01:07:45]         _0 = (*_8);
[01:07:45]         StorageDead(_5);
[01:07:45]         StorageDead(_7);
[01:07:45]         StorageDead(_6);
[01:07:45]         StorageDead(_4);
[01:07:45]         StorageDead(_3);
[01:07:45]         return;
[01:07:45] }', tools/compiletest/src/runtest.rs:2939:13
[01:07:45] 
[01:07:45] ---- [mir-opt] mir-opt/inline-closure.rs stdout ----
[01:07:45] ---- [mir-opt] mir-opt/inline-closure.rs stdout ----
[01:07:45] thread '[mir-opt] mir-opt/inline-closure.rs' panicked at 'Did not find expected line, error: ran out of mir dump to match against
[01:07:45] Expected Line: "    _3 = [closure@NodeId(39)];"
[01:07:45] Test Name: rustc.foo.Inline.after.mir
[01:07:45] ... (elided)
[01:07:45] ... (elided)
[01:07:45] bb0: {
[01:07:45] ... (elided)
[01:07:45] ... (elided)
[01:07:45]     _3 = [closure@NodeId(39)];
[01:07:45] ... (elided)
[01:07:45]     _4 = &_3;
[01:07:45] ... (elided)
[01:07:45]     _6 = _2;
[01:07:45] ... (elided)
[01:07:45]     _7 = _2;
[01:07:45]     _5 = (move _6, move _7);
[01:07:45]     _8 = move (_5.0: i32);
[01:07:45]     [mir-opt] mir-opt/inline-closure.rs
[01:07:45]     [mir-opt] mir-opt/retag.rs
[01:07:45] 
[01:07:45] test result: FAILED. 38 passed; 7 failed; 0 ignored; 0 measured; 0 filtered out
[01:07:45] test result: FAILED. 38 passed; 7 failed; 0 ignored; 0 measured; 0 filtered out
[01:07:45] 
[01:07:45] 
[01:07:45] 
[01:07:45] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/mir-opt" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "mir-opt" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:07:45] 
[01:07:45] 
[01:07:45] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:07:45] Build completed unsuccessfully in 0:19:34
[01:07:45] Build completed unsuccessfully in 0:19:34
[01:07:45] Makefile:58: recipe for target 'check' failed
[01:07:45] make: *** [check] Error 1
134668 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u
134668 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u
134664 ./obj/build/bootstrap/debug/incremental/bootstrap-zemjd6kcyh2u/s-f6h5p1l2eb-tliqph-22tmsi8iacpi9
130756 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu
130752 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
123680 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
123608 ./obj/build/x86_64-unknown-linux-gnu/test/mir-opt
---
travis_time:end:16fb993d:start=1541674521028841518,finish=1541674521035958272,duration=7116754
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:162991d4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf tr

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0a4903a9:start=1541685757074815692,finish=1541685960292349595,duration=203217533903
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:53:07] .................................................................................................... 100/4999
[00:53:11] .................................................................................................... 200/4999
[00:53:14] ........................................................................ii...................ii..... 300/4999
[00:53:17] ...........................................................................................iii...... 400/4999
[00:53:20] ..iiiiiiii.iii...........................iii...........................................i...........i 500/4999
[00:53:28] .................................................................................................... 700/4999
[00:53:34] .....................................................................i...........i.................. 800/4999
[00:53:37] ........................................................................................iiiii....... 900/4999
[00:53:41] ...........ii.iiii.................................................................................. 1000/4999
---
[00:54:20] .................................................................................................... 2200/4999
[00:54:25] .................................................................................................... 2300/4999
[00:54:29] .................................................................................................... 2400/4999
[00:54:33] .................................................................................................... 2500/4999
[00:54:37] ...................................................................iiiiiiiii........................ 2600/4999
[00:54:45] ...............................ii................................................................... 2800/4999
[00:54:48] .................................................................................................... 2900/4999
[00:54:52] .................................................................................................... 3000/4999
[00:54:55] ..........................i......................................................................... 3100/4999
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:16] 
[01:09:16] running 115 tests
[01:09:19] i..ii...iii..iii.....i...i.........i..iii...........i.....i.....ii...i..i.ii..............i...ii..ii 100/115
[01:09:19] .i....iiii.....
[01:09:19] 
[01:09:19]  finished in 3.593
[01:09:19] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:34] 
[01:09:34] running 118 tests
[01:09:59] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[01:10:03] ......iii.i.....ii
[01:10:03] 
[01:10:03]  finished in 29.168
[01:10:03] travis_fold:end:test_debuginfo

---
travis_time:start:test_run-pass-fulldeps
Check compiletest suite=run-pass-fulldeps mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:10:42] 
[01:10:42] running 97 tests
[01:12:44] ......................................F.....................test [run-pass] run-pass-fulldeps/myriad-closures.rs has been running for over 60 seconds
[01:15:26] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:503:22
[01:15:26] failures:
[01:15:26] 
[01:15:26] ---- [run-pass] run-pass-fulldeps/mbe_matching_test_macro.rs stdout ----
[01:15:26] ---- [run-pass] run-pass-fulldeps/mbe_matching_test_macro.rs stdout ----
[01:15:26] 
[01:15:26] error: auxiliary build of "/checkout/src/test/run-pass-fulldeps/auxiliary/procedural_mbe_matching.rs" failed to compile: 
[01:15:26] status: exit code: 1
[01:15:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass-fulldeps/auxiliary/procedural_mbe_matching.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/mbe_matching_test_macro/auxiliary" "-Crpath" "-O" "-Zunstable-options" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/mbe_matching_test_macro/auxiliary"
[01:15:26] ------------------------------------------
[01:15:26] 
[01:15:26] ------------------------------------------
[01:15:26] stderr:
[01:15:26] stderr:
[01:15:26] ------------------------------------------
[01:15:26] {"message":"unused import: `quote_tokens!(cx, $$matched:expr, $$($$pat:pat)|+)`","code":{"code":"unused_imports","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/procedural_mbe_matching.rs","byte_start":1334,"byte_end":1384,"line_start":38,"line_end":38,"column_start":23,"column_end":73,"is_primary":true,"text":[{"text":"    let mbe_matcher = quote_tokens!(cx, $$matched:expr, $$($$pat:pat)|+);","highlight_start":23,"highlight_end":73}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(unused_imports)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: unused import: `quote_tokens!(cx, $$matched:expr, $$($$pat:pat)|+)`\n  --> /checkout/src/test/run-pass-fulldeps/auxiliary/procedural_mbe_matching.rs:38:23\n   |\nLL |     let mbe_matcher = quote_tokens!(cx, $$matched:expr, $$($$pat:pat)|+);\n   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(unused_imports)] on by default\n\n"}
[01:15:26] {"message":"no function or associated item named `new` found for type `syntax::ast::NodeId` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/procedural_mbe_matching.rs","byte_start":1790,"byte_end":1801,"line_start":46,"line_end":46,"column_start":37,"column_end":48,"is_primary":true,"text":[{"text":"                                    NodeId::new(0));","highlight_start":37,"highlight_end":48}],"label":"function or associated item not found in `syntax::ast::NodeId`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"items from traits can only be used if the trait is in scope","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"the following trait is implemented but not in scope, perhaps add a `use` for it:","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/run-pass-fulldeps/auxiliary/procedural_mbe_matching.rs","byte_start":652,"byte_end":652,"line_start":21,"line_end":21,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"use syntax::feature_gate::Features;","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use rustc_data_structures::indexed_vec::Idx;\n","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0599]: no function or associated item named `new` found for type `syntax::ast::NodeId` in the current scope\n  --> /checkout/src/test/run-pass-fulldeps/auxiliary/procedural_mbe_matching.rs:46:37\n   |\nLL |                                     NodeId::new(0));\n   |                                     ^^^^^^^^^^^ function or associated item not found in `syntax::ast::NodeId`\n   |\n   = help: items from traits can only be used if the trait is in scope\nhelp: the following trait is implemented but not in scope, perhaps add a `use` for it:\n   |\nLL | use rustc_data_structures::indexed_vec::Idx;\n   |\n\n"}
[01:15:26] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:15:26] {"message":"For more information about this error, try `rustc --explain E0599`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0599`.\n"}
[01:15:26] ------------------------------------------
[01:15:26] 
[01:15:26] thread '[run-pass] run-pass-fulldeps/mbe_matching_test_macro.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3284:9
[01:15:26] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[01:15:26] test result: FAILED. 96 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:15:26] 
[01:15:26] 
[01:15:26] 
[01:15:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:15:26] 
[01:15:26] 
[01:15:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:15:26] Build completed unsuccessfully in 0:26:18
[01:15:26] Build completed unsuccessfully in 0:26:18
[01:15:26] Makefile:58: recipe for target 'check' failed
[01:15:26] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0068d5b0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:170c5a64:start=1541697992439280097,finish=1541698046487232785,duration=54047952688
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:52:50] .................................................................................................... 100/4999
[00:52:53] .................................................................................................... 200/4999
[00:52:56] ........................................................................ii...................ii..... 300/4999
[00:52:58] ...........................................................................................iii...... 400/4999
[00:53:01] ..iiiiiiii.iii...........................iii...........................................i...........i 500/4999
[00:53:08] .................................................................................................... 700/4999
[00:53:15] .....................................................................i...........i.................. 800/4999
[00:53:18] ........................................................................................iiiii....... 900/4999
[00:53:21] ...........ii.iiii.................................................................................. 1000/4999
---
[00:53:57] .................................................................................................... 2200/4999
[00:54:02] .................................................................................................... 2300/4999
[00:54:05] .................................................................................................... 2400/4999
[00:54:09] .................................................................................................... 2500/4999
[00:54:13] ...................................................................iiiiiiiii........................ 2600/4999
[00:54:20] ...............................ii................................................................... 2800/4999
[00:54:22] .................................................................................................... 2900/4999
[00:54:26] .................................................................................................... 3000/4999
[00:54:29] ..........................i......................................................................... 3100/4999
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:08:33] 
[01:08:33] running 115 tests
[01:08:36] i..ii...iii..iii.....i...i.........i..iii...........i.....i.....ii...i..i.ii..............i...ii..ii 100/115
[01:08:37] .i....iiii.....
[01:08:37] 
[01:08:37]  finished in 3.498
[01:08:37] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:08:51] 
[01:08:51] running 118 tests
[01:09:14] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[01:09:17] ......iii.i.....ii
[01:09:17] 
[01:09:17]  finished in 26.735
[01:09:17] travis_fold:end:test_debuginfo

---
[01:34:05] travis_fold:start:test_stage1-rustc_driver
travis_time:start:test_stage1-rustc_driver
Testing rustc_driver stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:34:05]    Compiling rustc_driver v0.0.0 (/checkout/src/librustc_driver)
[01:34:06] error[E0423]: expected function, found struct `hir::ItemLocalId`
[01:34:06]    --> librustc_driver/test.rs:235:17
[01:34:06]     |
[01:34:06] 235 |             id: hir::ItemLocalId(1),
[01:34:06]     |                 ^^^^^^^^^^^^^^^^ did you mean `hir::ItemLocalId { /* fields */ }`?
[01:34:06] 
[01:34:06] error[E0423]: expected function, found struct `hir::ItemLocalId`
[01:34:06]    --> librustc_driver/test.rs:241:21
[01:34:06]     |
[01:34:06] 241 |                 id: hir::ItemLocalId(1),
[01:34:06]     |                     ^^^^^^^^^^^^^^^^ did you mean `hir::ItemLocalId { /* fields */ }`?
[01:34:06] 
[01:34:06] error[E0423]: expected function, found struct `hir::ItemLocalId`
[01:34:06]    --> librustc_driver/test.rs:244:29
[01:34:06]     |
[01:34:06] 244 |                         id: hir::ItemLocalId(10),
[01:34:06]     |                             ^^^^^^^^^^^^^^^^ did you mean `hir::ItemLocalId { /* fields */ }`?
[01:34:06] 
[01:34:06] error[E0423]: expected function, found struct `hir::ItemLocalId`
[01:34:06]    --> librustc_driver/test.rs:248:29
[01:34:06]     |
[01:34:06] 248 |                         id: hir::ItemLocalId(11),
[01:34:06]     |                             ^^^^^^^^^^^^^^^^ did you mean `hir::ItemLocalId { /* fields */ }`?
[01:34:06] 
[01:34:06] error[E0423]: expected function, found struct `hir::ItemLocalId`
[01:34:06]    --> librustc_driver/test.rs:403:17
[01:34:06]     |
[01:34:06] 403 |             id: hir::ItemLocalId(id),
[01:34:06]     |                 ^^^^^^^^^^^^^^^^ did you mean `hir::ItemLocalId { /* fields */ }`?
[01:34:07] error: aborting due to 5 previous errors
[01:34:07] 
[01:34:07] For more information about this error, try `rustc --explain E0423`.
[01:34:07] error: Could not compile `rustc_driver`.
[01:34:07] error: Could not compile `rustc_driver`.
[01:34:07] 
[01:34:07] To learn more, run the command again with --verbose.
[01:34:07] 
[01:34:07] 
[01:34:07] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_driver" "--" "--quiet"
[01:34:07] 
[01:34:07] 
[01:34:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:34:07] Build completed unsuccessfully in 0:45:04
[01:34:07] Build completed unsuccessfully in 0:45:04
[01:34:07] Makefile:58: recipe for target 'check' failed
[01:34:07] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:01632ced
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

impl ItemLocalId {
pub fn as_usize(&self) -> usize {
self.0 as usize
// hack to ensure that we don't try to access the private parts of `NodeId` in this module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ItemLocalId instead of NodeId, I guess.

@michaelwoerister
Copy link
Member

Looks good! r=me with the rest of the fallout fixed.

@bors
Copy link
Contributor

bors commented Nov 11, 2018

☔ The latest upstream changes (presumably #55660) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 12, 2018

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Nov 12, 2018

📌 Commit 2203959 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 15, 2018
Make `NodeId` and `HirLocalId` `newtype_index`
bors added a commit that referenced this pull request Nov 15, 2018
Rollup of 17 pull requests

Successful merges:

 - #55182 (Redox: Update to new changes)
 - #55211 (Add BufWriter::buffer method)
 - #55507 (Add link to std::mem::size_of to size_of intrinsic documentation)
 - #55530 (Speed up String::from_utf16)
 - #55556 (Use `Mmap` to open the rmeta file.)
 - #55622 (NetBSD: link libstd with librt in addition to libpthread)
 - #55750 (Make `NodeId` and `HirLocalId` `newtype_index`)
 - #55778 (Wrap some query results in `Lrc`.)
 - #55781 (More precise spans for temps and their drops)
 - #55785 (Add mem::forget_unsized() for forgetting unsized values)
 - #55852 (Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint)
 - #55865 (Unix RwLock: avoid racy access to write_locked)
 - #55901 (fix various typos in doc comments)
 - #55926 (Change sidebar selector to fix compatibility with docs.rs)
 - #55930 (A handful of hir tweaks)
 - #55932 (core/char: Speed up `to_digit()` for `radix <= 10`)
 - #55956 (add tests for some fixed ICEs)

Failed merges:

r? @ghost
@bors bors merged commit 2203959 into rust-lang:master Nov 15, 2018
@oli-obk oli-obk deleted the node_id_x branch June 15, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants