Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VariantIdx type and use instead of usize #55589

Merged
merged 6 commits into from
Nov 13, 2018
Merged

Add VariantIdx type and use instead of usize #55589

merged 6 commits into from
Nov 13, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 1, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2018
@oli-obk

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@oli-obk

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@oli-obk

This comment has been minimized.

Sign in to view
@rust-timer

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 2, 2018

@bors try

@bors
Copy link
Contributor

bors commented Nov 2, 2018

⌛ Trying commit 34f848d17be42478dbd3d4f3f3f0fac3c75c2cfe with merge 49e6d10114075b7777aba504871f5fb272092c41...

@bors
Copy link
Contributor

bors commented Nov 2, 2018

☀️ Test successful - status-travis
State: approved= try=True

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 2, 2018

@rust-timer build 49e6d10114075b7777aba504871f5fb272092c41

@rust-timer
Copy link
Collaborator

Success: Queued 49e6d10114075b7777aba504871f5fb272092c41 with parent e800988, comparison URL.

@pnkfelix
Copy link
Member

pnkfelix commented Nov 5, 2018 •
edited
Loading

@oli-obk unfortunately the "comparison URL" linked above does not seem to work

  • update: oh, I forgot rust-timer puts up the url before the run has completed

Is this PR to be considered blocked on getting perf results?

(From what I skimmed, it seemed fine, but I can understand wanting to wait until we get actual numbers...)

@pnkfelix pnkfelix added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2018
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 49e6d10114075b7777aba504871f5fb272092c41

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 6, 2018

Timer finished successfully. Looks like 0.1% to 0.5% regressions over the board and a few spurious ones with 2%-4% (marked with ? for fluctuating)

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 6, 2018

rebased

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 6, 2018

Is this PR to be considered blocked on getting perf results?

Yea, I considered it blocked, because we've seen perf regressions with moving to strong index types before.

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 12, 2018

@bors r=pnkfelix

@bors
Copy link
Contributor

bors commented Nov 12, 2018

📌 Commit d46a207 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2018
@bors
Copy link
Contributor

bors commented Nov 12, 2018

⌛ Testing commit d46a207 with merge 1d65f669350f16f339c3db775031b2b5dabaa46e...

@bors
Copy link
Contributor

bors commented Nov 12, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 12, 2018

@bors retry 3h timeout on one builder

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2018
@kennytm kennytm mentioned this pull request Nov 13, 2018
Merged
@bors
Copy link
Contributor

bors commented Nov 13, 2018

⌛ Testing commit d46a207 with merge 485397e...

bors added a commit that referenced this pull request Nov 13, 2018
@bors
Auto merge of #55589 - oli-obk:min_length_💣, r=pnkfelix
485397e 
Add `VariantIdx` type and use instead of `usize`
@bors
Copy link
Contributor

bors commented Nov 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 485397e to master...

@bors bors merged commit d46a207 into rust-lang:master Nov 13, 2018
@bors bors mentioned this pull request Nov 13, 2018
Merged
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #55589!

Tested on commit 485397e.
Direct link to PR: #55589

🎉 rls on linux: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Nov 13, 2018
@rust-highfive
📣 Toolstate changed by rust-lang/rust#55589!
dc95078 
Tested on commit rust-lang/rust@485397e.
Direct link to PR: <rust-lang/rust#55589>

🎉 rls on linux: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
@bors bors mentioned this pull request Nov 13, 2018
Merged
@oli-obk oli-obk deleted the min_length_💣 branch November 13, 2018 09:52
This was referenced Nov 13, 2018
Merged
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @bors @rust-timer @pnkfelix @RalfJung