Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stdsimd to branch with breaking bugfix #55538

Closed
wants to merge 1 commit into from
Closed

Update stdsimd to branch with breaking bugfix #55538

wants to merge 1 commit into from

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Oct 31, 2018 •
edited
Loading

DO NOT MERGE

This updates stdsimd to the test-fix branch containing this PR (rust-lang/stdarch#576) with a breaking soundness bugfix.

The plan was to schedule a crater run before merging this PR into stdsimd upstream.

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2018
@alexcrichton
Copy link
Member

@bors: try

@bors
Copy link
Contributor

bors commented Oct 31, 2018

⌛ Trying commit f0fecde with merge d781639...

bors added a commit that referenced this pull request Oct 31, 2018
@bors
Auto merge of #55538 - gnzlbg:crater_stdsimd_bug, r=<try>
d781639 
Update stdsimd to branch with breaking bugfix

**DO NOT MERGE**

---

This updates `stdsimd` to the `test-fix` branch containing this PR (rust-lang/stdarch#576) with a breaking soundness bugfix.

The plan was to schedule a crater run before merging this PR into stdsimd upstream.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Oct 31, 2018

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton
Copy link
Member

@craterbot run start=master#05812fa8c588473f03e3fa7cf59cd84f4f37c715 end=try#d7816399d50d407bbce1efe9dbadf8faaaf568fc mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-55538 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment pr-55538 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-55538 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 2, 2018
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 2, 2018

@alexcrichton looks like there are two regressions, but they do look spurious.

@alexcrichton
Copy link
Member

Agreed! I think this indicates that it should be safe to land the change. Shall we land the stdsimd PR on master, then update this one and land it?

@alexcrichton alexcrichton mentioned this pull request Nov 2, 2018
Merged
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 2, 2018

I'll send a new PR to rust-lang rust updating stdsimd to stdsimd/master

@gnzlbg gnzlbg closed this Nov 2, 2018
@alexcrichton alexcrichton mentioned this pull request Nov 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnzlbg @rust-highfive @alexcrichton @bors @craterbot