Partially revert 674a5db "Fix undesirable fallout [from macro modularization]" #54209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@petrochenkov um, none of those tests appear to be named Was this meant to be tagged as fixing a different issue? Or am I missing something? |
|
(okay, I am starting to see a connection, in that this PR moves a bunch of macros in various tests from statement back to expression position, which was identified as the root cause here: #53675 (comment) ) |
|
In any case this PR seems like it is worth landing, but I don't think it should be tagged as "fixing" #53675 since it doesn't have a test of the original regression. (I'll just make a PR with that trivial test now.) |
|
@bors r+ rollup |
|
📌 Commit 0a0d642 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 16, 2018
Partially revert 674a5db "Fix undesirable fallout [from macro modularization]" Partially revert rust-lang@674a5db ~~Closes~~ (see pnkfelix comments below) rust-lang#53675
bors
added a commit
that referenced
this pull request
Sep 16, 2018
Rollup of 5 pull requests Successful merges: - #53941 (rustdoc: Sort implementors) - #54181 (Suggest && and || instead of 'and' and 'or') - #54209 (Partially revert 674a5db "Fix undesirable fallout [from macro modularization]") - #54213 (De-overlap the lifetimes of `flow_inits` and `flow_{un,ever_}inits`.) - #54244 (Add a small search box to seach Rust's standary library) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert 674a5db
Closes(see pnkfelix comments below) #53675