Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compute padding of braces unless they are unmatched #54092

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Don't compute padding of braces unless they are unmatched #54092

merged 1 commit into from
Sep 11, 2018

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 9, 2018

Follow up to #53949. Attempt to fix # #54083.

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2018
@estebank
Copy link
Contributor Author

estebank commented Sep 9, 2018

@bors try

@bors
Copy link
Contributor

bors commented Sep 9, 2018

⌛ Trying commit 014a56c with merge ff274ae...

bors added a commit that referenced this pull request Sep 9, 2018
@bors
Auto merge of #54092 - estebank:gotta-go-fast, r=<try>
ff274ae 
Don't compute padding of braces unless they are unmatched

Follow up to #53949. Attempt to fix # #54083.

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Sep 10, 2018

☀️ Test successful - status-travis
State: approved= try=True

@estebank
Copy link
Contributor Author

@rust-timer build ff274ae

@rust-timer
Copy link
Collaborator

Insufficient permissions to issue commands to rust-timer.

@estebank
Copy link
Contributor Author

@rust-lang/infra can I get a perf run to verify this is enough to revert the regression I introduced?

@varkor
Copy link
Member

varkor commented Sep 10, 2018 •
edited
Loading

@rust-timer build ff274ae

@rust-timer

This comment has been minimized.

Sign in to view
1 similar comment
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Success: Queued ff274ae with parent f50b775, comparison URL.

@alexcrichton
Copy link
Member

It looks like the parent commit is missing, but this comparison should should the performance difference from before the original change to after this change. (when it's filled in)

@alexcrichton
Copy link
Member

FWIW this is affecting wasm-bindgen as well where our "massively generated crate" now takes what appears to be hours to compile when all the features are enabled, I believe from some quick profiling in parsing/tokenization functions (almost for sure this PR). Just another data point!

@nikomatsakis
Copy link
Contributor

If I understand @alexcrichton correctly, then the perf results here look very good.

@nikomatsakis
Copy link
Contributor

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Sep 10, 2018

📌 Commit 014a56c has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2018
@Mark-Simulacrum
Copy link
Member

@bors p=5 we need this for master -> beta promotion.

@bors
Copy link
Contributor

bors commented Sep 11, 2018

⌛ Testing commit 014a56c with merge d6720cc...

bors added a commit that referenced this pull request Sep 11, 2018
@bors
Auto merge of #54092 - estebank:gotta-go-fast, r=nikomatsakis
d6720cc 
Don't compute padding of braces unless they are unmatched

Follow up to #53949. Attempt to fix # #54083.

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Sep 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing d6720cc to master...

@bors bors merged commit 014a56c into rust-lang:master Sep 11, 2018
@bors bors mentioned this pull request Sep 11, 2018
Closed
@arielb1 arielb1 mentioned this pull request Dec 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@estebank @bors @rust-timer @varkor @alexcrichton @nikomatsakis @Mark-Simulacrum @rust-highfive