Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest dereferencing in macro #53727

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

estebank
Copy link
Contributor

Fix #52783.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2018
@rust-highfive

This comment has been minimized.

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 27, 2018

📌 Commit a2722f3 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 28, 2018
…, r=nikomatsakis

Do not suggest dereferencing in macro

Fix rust-lang#52783.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 28, 2018
…, r=nikomatsakis

Do not suggest dereferencing in macro

Fix rust-lang#52783.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
…, r=nikomatsakis

Do not suggest dereferencing in macro

Fix rust-lang#52783.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
…, r=nikomatsakis

Do not suggest dereferencing in macro

Fix rust-lang#52783.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 30, 2018
…, r=nikomatsakis

Do not suggest dereferencing in macro

Fix rust-lang#52783.
bors added a commit that referenced this pull request Aug 31, 2018
Rollup of 20 pull requests

Successful merges:

 - #51760 (Add another PartialEq example)
 - #53113 (Add example for Cow)
 - #53129 (remove `let x = baz` which was obscuring the real error)
 - #53389 (document effect of join on memory ordering)
 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53476 (Add partialeq implementation for TryFromIntError type)
 - #53513 (Force-inline `shallow_resolve` at its hottest call site.)
 - #53655 (set applicability)
 - #53702 (Fix stabilisation version for macro_vis_matcher.)
 - #53727 (Do not suggest dereferencing in macro)
 - #53732 (save-analysis: Differentiate foreign functions and statics.)
 - #53740 (add llvm-readobj to llvm-tools-preview)
 - #53743 (fix a typo: taget_env -> target_env)
 - #53747 (Rustdoc fixes)
 - #53753 (expand keep-stage --help text)
 - #53756 (Fix typo in comment)
 - #53768 (move file-extension based .gitignore down to src/)
 - #53785 (Fix a comment in src/libcore/slice/mod.rs)
 - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.)
 - #53806 (Fix UI issues on Implementations on Foreign types)

Failed merges:

r? @ghost
@bors bors merged commit a2722f3 into rust-lang:master Aug 31, 2018
@estebank estebank deleted the incorrect-deref-suggestion branch November 9, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants