Don't reduce E0161 to a warning in NLL migrate mode #53575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #53581) made this pull request unmergeable. Please resolve the merge conflicts. |
* Sized checking in MIR should be a hard error in all borrowck modes * box operands should be an error even with unsized locals
Update another test that broke due to E0161 no longer being buffered
matthewjasper
force-pushed
the
unsized-is-an-error
branch
from
ec4ec3b
to
cd92da8
Compare
|
Ping from triage @pnkfelix! This PR needs your review. |
|
Ping from triage @pnkfelix / @rust-lang/compiler: This PR requires your review. |
|
@bors r+ |
|
📌 Commit cd92da8 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit cd92da8 with merge dd89cb727553577e9917c27788ce8d907c49be40... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors: r=estebank |
|
@matthewjasper: 🔑 Insufficient privileges: Not in reviewers |
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 6, 2018
Don't reduce E0161 to a warning in NLL migrate mode This error has been on stable for a while, and allowing such code cause the compile to later ICE (since we can't codegen it). Errors `box UNSIZED EXPR` with unsized locals because it's not compatible with the current evaluation order (create the box before evaluating the expressions). cc #53469 (fixes the ICE in this case) cc @qnighy
|
☀️ Test successful - status-appveyor, status-travis |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error has been on stable for a while, and allowing such code cause the compile to later ICE (since we can't codegen it). Errors
box UNSIZED EXPRwith unsized locals because it's not compatible with the current evaluation order (create the box before evaluating the expressions).cc #53469 (fixes the ICE in this case)
cc @qnighy