Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make more ported compile fail tests more robust w.r.t. NLL #53407

Merged
merged 4 commits into from
Aug 17, 2018
Merged

make more ported compile fail tests more robust w.r.t. NLL #53407

merged 4 commits into from
Aug 17, 2018

Commits on Aug 15, 2018

  1. Removed ignore-test-compare-mode-nll from borrowck-closures-unique.rs 

    by strengthening the tests there.

In almost all cases the strengthening amount to just encoding a use
that models the original lexical lifetime. A more invasive revision
was made in one case where it seems the actual issue is MIR-borrowck's
greater "knowledge" of unreachable code in the control flow...
    @pnkfelix
    pnkfelix committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    dd9f84f View commit details
    Browse the repository at this point in the history

  2. Removed ignore-test-compare-mode-nll from borrowck-closures-two-mut… 

    …-fail.rs

by strengthening the tests there.
    @pnkfelix
    pnkfelix committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    fb3ccb2 View commit details
    Browse the repository at this point in the history

  3. Removed ignore-test-compare-mode-nll from hashmap-lifetimes.rs 

    by strengthening the test there.
    @pnkfelix
    pnkfelix committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    f8084c6 View commit details
    Browse the repository at this point in the history

  4. Removed ignore-test-compare-mode-nll from unboxed-closures tests 

    by strengthening the tests (by adding no-op references to the
closures doing the borrows after the conflicting borrows, thus
forcing the lifetimes to resemble lexical scopes even under NLL).
    @pnkfelix
    pnkfelix committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    cd89fdb View commit details
    Browse the repository at this point in the history