Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some ported cfail tests robust w.r.t. NLL #53369

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Make some ported cfail tests robust w.r.t. NLL #53369

merged 1 commit into from
Aug 18, 2018

Conversation

pnkfelix
Copy link
Member

Updated the most glaring instances of weak tests w.r.t. NLL that came from #53196.

See also the bulletpoint list on #53351.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2018
@pnkfelix pnkfelix mentioned this pull request Aug 14, 2018
Closed
49 tasks
@pnkfelix
Copy link
Member Author

r? @davidtwco

davidtwco
davidtwco approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alexcrichton
Copy link
Member

@bors: r=davidtwco delegate=davidtwco

@bors
Copy link
Contributor

bors commented Aug 15, 2018

✌️ @davidtwco can now approve this pull request

@bors
Copy link
Contributor

bors commented Aug 15, 2018

📌 Commit c7041a6 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2018
@pnkfelix pnkfelix mentioned this pull request Aug 15, 2018
Merged
@bors
Copy link
Contributor

bors commented Aug 17, 2018

⌛ Testing commit c7041a6 with merge 67cd9f6d77efce03f15569d84024b77bd38ed6a0...

@bors
Copy link
Contributor

bors commented Aug 17, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2018
@kennytm
Copy link
Member

kennytm commented Aug 17, 2018

@bors retry GitHub archive issue.

10:48 HKT — We're currently experiencing elevated failure rates downloading repository archives.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2018
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 17, 2018
@frewsxcv
Rollup merge of rust-lang#53407 - pnkfelix:partial-53351-make-more-po…
5ad7b91 
…rted-compile-fail-tests-more-robust-wrt-nll, r=nikomatsakis

make more ported compile fail tests more robust w.r.t. NLL

This is similar to PR rust-lang#53369, except it covers a disjoint (and much smaller) set of tests that I needed to look at more carefully before being 100% certain they were the same kind of issue.
@bors
Copy link
Contributor

bors commented Aug 17, 2018

⌛ Testing commit c7041a6 with merge 4d5ef32...

bors added a commit that referenced this pull request Aug 17, 2018
@bors
Auto merge of #53369 - pnkfelix:partial-53351-make-some-ported-compil…
4d5ef32 
…e-fail-tests-more-robust-wrt-nll, r=davidtwco

Make some ported cfail tests robust w.r.t. NLL

Updated the most glaring instances of weak tests w.r.t. NLL that came from #53196.

See also the bulletpoint list on #53351.
@bors
Copy link
Contributor

bors commented Aug 18, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: davidtwco
Pushing 4d5ef32 to master...

@bors bors merged commit c7041a6 into rust-lang:master Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pnkfelix @rust-highfive @alexcrichton @bors @kennytm @davidtwco