Rollup of 12 pull requests #53206
Closed
Rollup of 12 pull requests #53206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary workaround for Fuchsia's libc not supporting TLS segments with alignments greater than 32 bytes. It should be reverted ASAP following the fix to libc.
When missing a comma in a macro call, suggest it, regardless of position. When a macro call doesn't match any of the patterns, check if the call's token stream could be missing a comma between two idents, and if so, create a new token stream containing the comma and try to match against the macro patterns. If successful, emit the suggestion.
…omatsakis Avoid unnecessary pattern matching against Option and Result
…=Mark-Simulacrum Move SmallVector and ThinVec out of libsyntax - move `libsyntax::util::SmallVector` tests to `librustc_data_structures::small_vec` - remove `libsyntax::util::SmallVector` - move `libsyntax::util::thin_vec` to `librustc_data_structures::thin_vec` Other than moving these data structures where they belong it allows modules using `SmallVector<T>` (`SmallVec<[T; 1]>`) to specify their own length (e.g. 8 or 32) independently from `libsyntax`.
Automatically expand section if url id point to one of its component Fixes rust-lang#52517. r? @nrc
…s, r=eddyb Fix improper_ctypes lint for individual foreign items Fixes rust-lang#52456. r? @eddyb
…=nrc Account for --remap-path-prefix in save-analysis Fixes rust-lang#52549. Didn't add a test since save-analysis is still unstable, only tested this locally. Should I add a test for that? If so, is run-make-fulldeps an appropriate format? Session is already created with remapped working directory, so use that instead of the actual cwd. This was the only place affected, since the rest of the paths in save-analysis are directly derived from files in spans from `sess.codemap()`, which already creates remapped ones. r? @nrc
…excrichton NetBSD: fix signedess of char
…static, r=nikomatsakis NLL says something "does not live long enough" when talking about a (thread-local) static Part of rust-lang#52663. r? @nikomatsakis
…tion-debuginfo-test, r=kennytm Re-enable drop-locations debuginfo tests. The `-O -C no-prepopulate-passes` workaround doesn't seem to be needed anymore, so it works again for my version of GDB. Let's see what CI says.
…ginfo-tests, r=kennytm Re-enable a bunch of debuginfo tests. Re-enable some more debuginfo tests that actually seem to work.
Avoid increased alignment of TLS segments on Fuchsia This is a temporary workaround for Fuchsia's libc not supporting TLS segments with alignments greater than 32 bytes. It should be reverted ASAP following the fix to libc. cc @petrhosek r? @alexcrichton
Suggest comma when missing in macro call When missing a comma in a macro call, suggest it, regardless of position. When a macro call doesn't match any of the patterns, check if the call's token stream could be missing a comma between two idents, and if so, create a new token stream containing the comma and try to match against the macro patterns. If successful, emit the suggestion. This works on arbitrary macros, with no need of special support from the macro writers. ``` error: no rules expected the token `d` --> $DIR/missing-comma.rs:26:18 | LL | foo!(a, b, c d, e); | -^ | | | help: missing comma here ``` Follow up to rust-lang#52397.
Fixes rust-lang#53119. Fixes rust-lang#53119. I minimized sample little bit more, but I checked the sample from issue too. r? @nikomatsakis
|
@bors r+ p=13 |
|
📌 Commit 888c158 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 888c158 with merge c06e6a0c1e3db2ebf56d8a7985537b913b0b39ec... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
gluon_basedoes not compile with NLL #53119.)Failed merges:
r? @ghost