optimize redundant borrows and escaping paths in NLL #53177

nikomatsakis · 2018-08-07T22:04:44Z

This builds on #53168 and adds a commit that addresses #53176 -- or at least I think it does. I marked this as WIP because I want to see the test results (and measure the performance). I also want to double check we're not adding in any unsoundness here.

In particular, we skip computing liveness for a variable X if all the regions in its type are known to outlive free regions.

rust-highfive · 2018-08-07T22:04:46Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

nikomatsakis · 2018-08-07T22:05:39Z

@bors try

bors · 2018-08-07T22:05:50Z

⌛ Trying commit 31fe3df6543566f5671da4d78b381b9d59f2d096 with merge a7a1e7a9bda496d4f9f0fbd27d7cd126b18e8047...

bors · 2018-08-07T23:40:57Z

☀️ Test successful - status-travis
State: approved= try=True

nikomatsakis · 2018-08-07T23:46:14Z

@rust-timer build a7a1e7a9bda496d4f9f0fbd27d7cd126b18e8047

rust-timer · 2018-08-07T23:46:15Z

Success: Queued a7a1e7a9bda496d4f9f0fbd27d7cd126b18e8047 with parent ccb550f, comparison URL.

kennytm · 2018-08-08T05:34:49Z

Perf is ready.

BurntPizza · 2018-08-08T05:51:08Z

*Clicks link*
*Falls out of chair*

nikomatsakis · 2018-08-08T08:40:10Z

So yeah, seems like a win. =)

nikomatsakis · 2018-08-08T10:23:45Z

So I pushed a comment that sort of convinces me that this logic is correct.

nikomatsakis · 2018-08-08T10:23:55Z

Removing [WIP] and I've closed #53168 in favor of this PR, since it does more.

nikomatsakis · 2018-08-08T12:04:01Z

r? @pnkfelix

kennytm · 2018-08-10T14:13:08Z

@bors retry #40474.

bors · 2018-08-10T14:34:20Z

⌛ Testing commit ff7f6d5 with merge 2c92308...

…g-values, r=pnkfelix optimize redundant borrows and escaping paths in NLL This builds on #53168 and adds a commit that addresses #53176 -- or at least I think it does. I marked this as WIP because I want to see the test results (and measure the performance). I also want to double check we're not adding in any unsoundness here.

bors · 2018-08-10T15:24:12Z

💔 Test failed - status-travis

rust-highfive · 2018-08-10T15:24:13Z

The job dist-powerpc-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

###################################################################       94.2%
######################################################################## 100.0%
[00:07:12] extracting /checkout/obj/build/cache/2018-08-01/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:07:14]     Updating registry `https://github.com/rust-lang/crates.io-index`
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-08-10T15:26:21Z

@bors retry #40474

bors · 2018-08-10T16:12:25Z

⌛ Testing commit ff7f6d5 with merge 19739a77689d041e02ef7b19be5730425676a165...

bors · 2018-08-10T16:54:12Z

💔 Test failed - status-travis

rust-highfive · 2018-08-10T16:54:13Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

  Downloading https://files.pythonhosted.org/packages/d1/a1/7790cc85db38daa874f6a2e6308131b9953feb1367f2ae2d1123bb93a9f5/pyasn1-0.4.4-py2.py3-none-any.whl (72kB)
Collecting futures<4.0.0,>=2.2.0; python_version == "2.6" or python_version == "2.7" (from s3transfer<0.2.0,>=0.1.12->awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Retrying (Retry(total=4, connect=None, read=None, redirect=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='pypi.python.org', port=443): Read timed out. (read timeout=15)",)': /simple/futures/
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/2d/99/b2c4e9d5a30f6471e410a146232b4118e697fa3ffc06d6a65efde84debd0/futures-3.2.0-py2-none-any.whl
Collecting jmespath<1.0.0,>=0.7.1 (from botocore==1.10.74->awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
---
########################                                                  34.0%
######################################################################## 100.0%
[00:06:44] extracting /checkout/obj/build/cache/2018-08-01/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:06:44]     Updating registry `https://github.com/rust-lang/crates.io-index`
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-08-10T16:58:12Z

@bors retry https://www.traviscistatus.com/incidents/pxj3py3xzn14

bors · 2018-08-10T19:18:29Z

⌛ Testing commit ff7f6d5 with merge 0aa8d03...

…g-values, r=pnkfelix optimize redundant borrows and escaping paths in NLL This builds on #53168 and adds a commit that addresses #53176 -- or at least I think it does. I marked this as WIP because I want to see the test results (and measure the performance). I also want to double check we're not adding in any unsoundness here.

bors · 2018-08-10T22:05:49Z

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 0aa8d03 to master...

nikomatsakis added 7 commits August 7, 2018 14:52

compute liveness later

fb1702f

update comment to more accurately describe the limitations

db7a07c

promote liveness to a directory module

5147d38

move liveness_map into the liveness module

d1ce8e8

liveness_map: rustfmt

a92bf8d

make it possible to customize the RegionGraph direction

887296e

avoid computing liveness when a variable doesn't need it

3b7989d

In particular, we skip computing liveness for a variable X if all the regions in its type are known to outlive free regions.

rust-highfive assigned eddyb Aug 7, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2018

nikomatsakis force-pushed the nll-redundant-borrows-and-escaping-values branch from 7204297 to 31fe3df Compare August 7, 2018 22:04

nikomatsakis mentioned this pull request Aug 7, 2018

[nll] teach SCC about 'static #53178

Closed

optimize redundant borrows

1bae4f5

This was referenced Aug 8, 2018

ReStatic ICE with nll and thread_local #51269

Closed

avoid computing liveness when possible #53168

Closed

nikomatsakis changed the title ~~[WIP] optimize redundant borrows and escaping paths in NLL~~ optimize redundant borrows and escaping paths in NLL Aug 8, 2018

rust-highfive assigned pnkfelix and unassigned eddyb Aug 8, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 10, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 10, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2018

bors merged commit ff7f6d5 into rust-lang:master Aug 10, 2018

This was referenced Aug 16, 2018

[nll] avoid liveness for values that escape into the output when in a static #52713

Closed

[nll] optimize redundant reborrows #53176

Closed

nikomatsakis mentioned this pull request Aug 27, 2018

Revert "Fix E0502 warnings" rust-lang/rust-clippy#3085

Merged

pnkfelix mentioned this pull request Sep 17, 2018

NLL: need a (new) round of review of deltas between .stderr and .nll.stderr output #52663

Closed

pnkfelix mentioned this pull request Oct 8, 2018

[1.30 beta] Test suite of the jemalloc-ctl crate is failing #54478

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimize redundant borrows and escaping paths in NLL #53177

optimize redundant borrows and escaping paths in NLL #53177

nikomatsakis commented Aug 7, 2018

rust-highfive commented Aug 7, 2018

nikomatsakis commented Aug 7, 2018

bors commented Aug 7, 2018

bors commented Aug 7, 2018

nikomatsakis commented Aug 7, 2018

rust-timer commented Aug 7, 2018

kennytm commented Aug 8, 2018

BurntPizza commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

kennytm commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

rust-highfive commented Aug 10, 2018

kennytm commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

rust-highfive commented Aug 10, 2018

kennytm commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

optimize redundant borrows and escaping paths in NLL #53177

optimize redundant borrows and escaping paths in NLL #53177

Conversation

nikomatsakis commented Aug 7, 2018

rust-highfive commented Aug 7, 2018

nikomatsakis commented Aug 7, 2018

bors commented Aug 7, 2018

bors commented Aug 7, 2018

nikomatsakis commented Aug 7, 2018

rust-timer commented Aug 7, 2018

kennytm commented Aug 8, 2018

BurntPizza commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

nikomatsakis commented Aug 8, 2018

kennytm commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

rust-highfive commented Aug 10, 2018

kennytm commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018

rust-highfive commented Aug 10, 2018

kennytm commented Aug 10, 2018

bors commented Aug 10, 2018

bors commented Aug 10, 2018