NLL mentions lifetimes that are not included in printed span(s). #52973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The definition point for the lifetime probably isn't the optimal thing to highlight... it would be nice, if we can do it, to highlight the relevant usage points (right)? That is, the points where the lifetime is used in the type(s) relevant to the error message. Having said that, this is better than nothing, especially since the relevant types are likely to be close to, perhaps even on the same line as, the definition point. |
|
@bors r+ |
|
📌 Commit 2488cb6 has been approved by |
bors
added
S-waiting-on-bors
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 2, 2018
…-included-in-span, r=pnkfelix NLL mentions lifetimes that are not included in printed span(s). Part of rust-lang#52663. r? @pnkfelix
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 2, 2018
…-included-in-span, r=pnkfelix NLL mentions lifetimes that are not included in printed span(s). Part of rust-lang#52663. r? @pnkfelix
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #52663.
r? @pnkfelix