Deny bare trait objects in src/bootstrap #52220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Eijebong
reviewed
Jul 10, 2018
src/bootstrap/lib.rs
Outdated
| @@ -113,7 +113,7 @@ | |||
| //! More documentation can be found in each respective module below, and you can | |||
| //! also check out the `src/bootstrap/README.md` file for more information. | |||
|
|
|||
| #![deny(warnings)] | |||
There was a problem hiding this comment.
Ah, you're right - I actually misread it as #![allow(warnings)] 🙈. I'll revert this bit.
|
@bors r+ rollup |
|
📌 Commit 72b908f has been approved by |
bors
added
S-waiting-on-bors
ljedrz
changed the title
src/bootstrap
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jul 12, 2018
Deny bare trait objects in `src/bootstrap` Enforce `#![deny(bare_trait_objects)]` in `src/bootstrap`.
bors
added a commit
that referenced
this pull request
Jul 12, 2018
Rollup of 9 pull requests Successful merges: - #51816 (bootstrap: write texts to a .tmp file first for atomicity) - #51912 (impl Clone for Box<CStr>, Box<OsStr>, Box<Path>) - #52164 (use proper footnote syntax for references) - #52220 (Deny bare trait objects in `src/bootstrap`) - #52276 (rustc: Verify #[proc_macro] is only a word) - #52277 (Uncapitalize "If") - #52287 (Deny bare trait objects in src/librustc_resolve) - #52295 (Deny bare trait objects in src/libsyntax_ext) - #52298 (make reference to dirs crate clickable in terminals) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce
#![deny(bare_trait_objects)]insrc/bootstrap.