rustdoc: Hide struct and enum variant constructor imports #52196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Whoops, i thought i had gotten it with that change you removed here, but i guess not. Thanks for the fix! r=me pending travis. re: backport, i don't think this is severe enough to warrant a backport, but it's worth seeing what the rest of @rust-lang/rustdoc thinks. |
|
I'd be in favor for a backport. |
QuietMisdreavus
added
beta-nominated
|
@bors r+ @steveklabnik Care to be the tiebreaking vote on whether to backport? |
|
📌 Commit 6b1d584 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 10, 2018
rustdoc: Hide struct and enum variant constructor imports This is fallout from #51425. The duplicate variant imports can be seen [here](https://doc.rust-lang.org/nightly/std/prelude/v1/index.html) for example. This is fixing a regression so could be backported to beta. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
|
Ping @rust-lang/rustdoc, should this be backported to beta? |
GuillaumeGomez
added
the
beta-accepted
|
Yes it should. |
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Jul 12, 2018
[beta] Rollup backports Merged and approved: * #51722: Updated RELEASES for 1.28.0 * #52193: step_by: leave time of item skip unspecified * #52194: Remove rustdoc's plugins feature * #52196: rustdoc: Hide struct and enum variant constructor imports * #52310: Backport 1.27.1 release notes to master r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fallout from #51425. The duplicate variant imports can be seen here for example.
This is fixing a regression so could be backported to beta.
r? @QuietMisdreavus