Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add structured suggestions and fix false-positive for elided-lifetimes-in-paths lint #52069

Commits on Jul 22, 2018

  1. in which the elided-lifetimes-in-paths lint undergoes a revolution

    The existing elided-lifetimes-in-paths lint (introduced in Nov. 2017's
    accd997 / rust-lang#46254) lacked stuctured suggestions and—much more
    alarmingly—produced false positives on associated functions (like
    `Ref::clone`) and on anonymous '_ lifetimes (!!—yes, the very
    anonymous lifetimes that we meant to suggest "instead"). That this
    went apparently unnoticed for so long maybe tells you something about
    how many people actually bother to flip on allow-by-default lints.
    
    After many hours of good old-fashioned American elbow grease—and a
    little help from expert reviewers—it turns out that getting the right
    answer is a lot easier if we fire the lint while lowering the Higher
    Intermediate Representation.
    
    The lint is promoted to the idioms-2018 group.
    
    Also, in the matter of test filenames, "elided" only has one 'l' (see,
    e.g., https://en.wiktionary.org/wiki/elide).
    
    Resolves rust-lang#52041.
    zackmdavis committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    41d5c0c View commit details
    Browse the repository at this point in the history