Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mem::swap the obvious way for types smaller than the SIMD optimization's block size #52051

Merged
merged 2 commits into from
Jul 22, 2018
Merged

mem::swap the obvious way for types smaller than the SIMD optimization's block size #52051

merged 2 commits into from
Jul 22, 2018

Commits on Jul 22, 2018

  1. Don't use SIMD in mem::swap for types smaller than the block size 

    LLVM isn't able to remove the alloca for the unaligned block in the SIMD tail in some cases, so doing this helps SRoA work in cases where it currently doesn't.  Found in the `replace_with` RFC discussion.
    @scottmcm
    scottmcm committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    e6fc62a View commit details
    Browse the repository at this point in the history

  2. Only run the test on x86_64 

    Smaller platforms don't merge the loads the same way.
    @scottmcm
    scottmcm committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    c9482f7 View commit details
    Browse the repository at this point in the history