Use in-tree libbacktrace on Fuchsia #51931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 3265189 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jun 30, 2018
…chton Use in-tree libbacktrace on Fuchsia cc @abarth r? @alexcrichton (welcome back! 😄 )
|
@cramertj any reasons for that? Using in-tree libbacktrace means that binaries get larger. Windows uses stuff from the system as well for backtraces. |
We're removing libbacktrace.so from the Fuchsia SDK because we cannot commit to the stability of its API. The library is not controlled by the Fuchsia project, which means our policies around API evolution don't apply to it. |
|
@abarth thanks for the explainer! |
bors
added a commit
that referenced
this pull request
Jul 2, 2018
Use in-tree libbacktrace on Fuchsia cc @abarth r? @alexcrichton (welcome back! 😄 )
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @abarth
r? @alexcrichton
(welcome back! 😄 )