use literal span for concrete type suggestion #51920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 28c4813 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 30, 2018
…estebank use literal span for concrete type suggestion Fixes rust-lang#51874. r? @estebank
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jun 30, 2018
…estebank use literal span for concrete type suggestion Fixes rust-lang#51874. r? @estebank
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jul 1, 2018
…estebank use literal span for concrete type suggestion Fixes rust-lang#51874. r? @estebank
bors
added a commit
that referenced
this pull request
Jul 1, 2018
Rollup of 7 pull requests Successful merges: - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.) - #51853 (Fix some doc links) - #51890 (Fix inconsequential typo in GlobalAlloc doc example) - #51920 (use literal span for concrete type suggestion) - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image) - #51936 (rename rustc's lld to rust-lld) - #51961 (Fix typo in /src/librustc_resolve/lib.rs) Failed merges: r? @ghost
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jul 1, 2018
…estebank use literal span for concrete type suggestion Fixes rust-lang#51874. r? @estebank
bors
added a commit
that referenced
this pull request
Jul 1, 2018
Rollup of 7 pull requests Successful merges: - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.) - #51853 (Fix some doc links) - #51890 (Fix inconsequential typo in GlobalAlloc doc example) - #51920 (use literal span for concrete type suggestion) - #51921 (improve the error message when `#[panic_implementation]` is missing) - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image) - #51961 (Fix typo in /src/librustc_resolve/lib.rs) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51874.
r? @estebank