Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest correct comparison against negative literal #51883

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

estebank
Copy link
Contributor

When parsing as emplacement syntax (x<-1), suggest the correct syntax
for comparison against a negative value (x< -1).

Fix #45651.

When parsing as emplacement syntax (`x<-1`), suggest the correct syntax
for comparison against a negative value (`x< -1`).
@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2018
@varkor
Copy link
Member

varkor commented Jun 29, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jun 29, 2018

@varkor: 🔑 Insufficient privileges: Not in reviewers

@estebank
Copy link
Contributor Author

@varkor that's odd, you should have the privs. @nikomatsakis, can you look at that?

Let's see if this works:

@bors r=varkor

@bors
Copy link
Contributor

bors commented Jun 29, 2018

📌 Commit 23d59d0 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2018
@varkor
Copy link
Member

varkor commented Jun 29, 2018

Well, that's one fewer errors than last time 😅Maybe @bors hasn't been restarted recently enough for the changes to have had effect.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 30, 2018
…rkor

Suggest correct comparison against negative literal

When parsing as emplacement syntax (`x<-1`), suggest the correct syntax
for comparison against a negative value (`x< -1`).

Fix rust-lang#45651.
kennytm added a commit to kennytm/rust that referenced this pull request Jun 30, 2018
…rkor

Suggest correct comparison against negative literal

When parsing as emplacement syntax (`x<-1`), suggest the correct syntax
for comparison against a negative value (`x< -1`).

Fix rust-lang#45651.
@bors
Copy link
Contributor

bors commented Jul 1, 2018

⌛ Testing commit 23d59d0 with merge ef9a322...

bors added a commit that referenced this pull request Jul 1, 2018
Suggest correct comparison against negative literal

When parsing as emplacement syntax (`x<-1`), suggest the correct syntax
for comparison against a negative value (`x< -1`).

Fix #45651.
@bors
Copy link
Contributor

bors commented Jul 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: varkor
Pushing ef9a322 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants