Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ICE when performing lower_pattern_unadjusted on a TyError #51789

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

estebank
Copy link
Contributor

Fix #50577. CC #51696.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Jun 25, 2018

r=me with Travis passing

@estebank
Copy link
Contributor Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 25, 2018

📌 Commit 7aab3bf has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jun 26, 2018
Don't ICE when performing `lower_pattern_unadjusted` on a `TyError`

Fix rust-lang#50577. CC rust-lang#51696.

r? @oli-obk
bors added a commit that referenced this pull request Jun 26, 2018
Rollup of 11 pull requests

Successful merges:

 - #51104 (add `dyn ` to display of dynamic (trait) types)
 - #51153 (Link panic and compile_error docs)
 - #51642 (Fix unknown windows build)
 - #51730 (New safe associated functions for PinMut)
 - #51731 (Fix ICEs when using continue as an array length inside closures (inside loop conditions))
 - #51747 (Add error for using null characters in #[export_name])
 - #51769 (Update broken rustc-guide links)
 - #51786 (Remove unnecessary stat64 pointer casts)
 - #51788 (Fix typo)
 - #51789 (Don't ICE when performing `lower_pattern_unadjusted` on a `TyError`)
 - #51791 (Minify css)

Failed merges:

r? @ghost
@bors bors merged commit 7aab3bf into rust-lang:master Jun 26, 2018
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 24, 2020
Fix ICE while building MIR with type errors

See rust-lang#74047 (comment) for background. Replacing a binding with `PatKind::Wild` (introduced in rust-lang#51789 and later refactored in rust-lang#67439) caused an ICE downstream while building MIR.

I noticed that taking this code out no longer triggers the ICEs it was added to prevent. I'm not sure what else changed, or if this change is _correct_, but it does seem to be passing ui tests at least.

r? @oli-obk
cc @estebank

Fixes rust-lang#74047.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants