Keyword doc #51581
Keyword doc #51581
Conversation
rust-highfive
added
the
S-waiting-on-review
src/tools/rustdoc-js/tester.js
Outdated
| errors += 1; | ||
| console.error("FAILED"); | ||
| console.error("==> Test was supposed to fail but all items were found..."); | ||
| } else if (error_text.length !== 0 && should_fail === false) { |
There was a problem hiding this comment.
Any particular reason you went with a new should_fail_happy variable instead of reusing error_text like the regular output does? Just the early return?
GuillaumeGomez
force-pushed
the
keyword-doc
branch
from
50b4406 to
1fcce48
Compare
|
|
||
| #[doc(keyword = "fn")] | ||
| // | ||
| /// The `fn` keyword. |
There was a problem hiding this comment.
Did we ever figure out if we needed the extra // between the regular attribute and the docs, or was that just for spacing?
There was a problem hiding this comment.
Just for spacing.
There was a problem hiding this comment.
Makes sense. It seems a bit weird to leave it in, but i won't let it hold up the PR.
|
Thanks so much for kicking this off! (And for picking the one that immediately led to a problem to fix, haha!) Hopefully with the file in place we can send the great checklist out for new contributors. r=me pending travis. |
|
@bors: r=QuietMisdreavus |
|
📌 Commit 1fcce48 has been approved by |
bors
added
S-waiting-on-bors
Keyword doc Part of #51451. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
Part of #51451.
r? @QuietMisdreavus