Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unstable feature message display #51563

Closed
wants to merge 1 commit into from
Closed

Improve unstable feature message display #51563

wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2018
@pietroalbini
Copy link
Member

Ping from triage @QuietMisdreavus! This PR needs your review.

@GuillaumeGomez
Copy link
Member Author

I need to modify it again after a discussion we had (putting the unstable message into the doc instead).

@pietroalbini pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2018
@pietroalbini
Copy link
Member

Ping from triage @GuillaumeGomez! It's been a while since we heard from you, will you have time to work on this again?

@GuillaumeGomez
Copy link
Member Author

I'll, just going through my TODO list by thanks for the reminder. :)

@TimNN
Copy link
Contributor

TimNN commented Jul 3, 2018

Ping from triage, @GuillaumeGomez!

@TimNN
Copy link
Contributor

TimNN commented Jul 10, 2018

Ping from triage, @GuillaumeGomez! We haven't heard from you in a while, so we are closing this PR. Feel free to re-open it in the future. Thanks for your contribution!

@TimNN TimNN closed this Jul 10, 2018
@TimNN TimNN added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2018
@GuillaumeGomez GuillaumeGomez deleted the unstable-message-display branch July 10, 2018 20:53
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 3, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 26, 2018
@GuillaumeGomez
Rollup merge of rust-lang#53043 - GuillaumeGomez:improve-unstable-msg…
49944ae 
…-display, r=QuietMisdreavus

Improve unstable message display

Fixes rust-lang#51387.
Reopening of rust-lang#51563.

New display:

<img width="1440" alt="screen shot 2018-08-04 at 00 01 39" src="https://user-images.githubusercontent.com/3050060/43667793-dc14f708-9779-11e8-9808-f3ff126fc213.png">

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @pietroalbini @TimNN @QuietMisdreavus @rust-highfive