Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce lifetime declarations into the lists of type parameters. #5141

Closed
wants to merge 1 commit into from
Closed

Introduce lifetime declarations into the lists of type parameters. #5141

wants to merge 1 commit into from

Conversation

nikomatsakis
Copy link
Contributor

Major changes are:

  • replace ~[ty_param] with Generics structure, which includes
    both OptVec and OptVec;
  • the use of syntax::opt_vec to avoid allocation for empty lists;

cc #4846

r? @graydon

@nikomatsakis
Copy link
Contributor Author

or r? @pcwalton (or anyone)

@nikomatsakis
Introduce lifetime declarations into the lists of type parameters.
c623d21 
Major changes are:
- replace ~[ty_param] with Generics structure, which includes
  both OptVec<TyParam> and OptVec<Lifetime>;
- the use of syntax::opt_vec to avoid allocation for empty lists;

cc rust-lang#4846
bors added a commit that referenced this pull request Feb 28, 2013
@bors
auto merge of #5141 : nikomatsakis/rust/region-syntax-expl-lifetimes,…
d0a1234 
… r=nikomatsakis

Major changes are:
- replace ~[ty_param] with Generics structure, which includes
  both OptVec<TyParam> and OptVec<Lifetime>;
- the use of syntax::opt_vec to avoid allocation for empty lists;

cc #4846

r? @graydon
@bors bors closed this Feb 28, 2013
@nikomatsakis nikomatsakis deleted the region-syntax-expl-lifetimes branch March 30, 2016 16:17
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
@bors
Auto merge of rust-lang#5141 - xiongmao86:issue5095, r=flip1995
6dcc8d5 
Fixes issue 5095

fixes rust-lang#5095.

- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`

[lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints

changelog: (internal) warn about collapsible `span_lint_and_then` calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikomatsakis @bors