Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Set opt-level to 3" #51165

Merged
merged 2 commits into from
May 29, 2018
Merged

Revert "Set opt-level to 3" #51165

merged 2 commits into from
May 29, 2018

Commits on May 29, 2018

  1. Revert "Set opt-level to 3" 

    This reverts commit aad9840.

Level 3 (possibly indirectly, the underlying bug might be in XCode’s linker)
causes unit tests to sefault when compiled with some versions of XCode:
rust-lang#50867

It also appears to cause some segfaults on Windows:
rust-lang#50329 (comment)

… and regressions in some rustc performance benchmarks:
rust-lang#50329 (comment)
    @SimonSapin
    SimonSapin committed May 29, 2018
    Configuration menu
    Copy the full SHA
    01e8616 View commit details
    Browse the repository at this point in the history

  2. Change the comment on opt-level = 2 to point to rust-lang#50867

    @SimonSapin
    SimonSapin committed May 29, 2018
    Configuration menu
    Copy the full SHA
    5067d2f View commit details
    Browse the repository at this point in the history