resolve: Make sure indeterminate and inconsistent macro resolutions always generate errors #51145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
force-pushed
the
npbot
branch
2 times, most recently
from
57edb04 to
da58ff4
Compare
|
@bors: r+ |
|
@bors r=alexcrichton |
|
📌 Commit da58ff4 has been approved by |
bors
added
S-waiting-on-bors
|
🔒 Merge conflict |
bors
added
S-waiting-on-author
…lways generate errors
|
@bors r=alexcrichton |
|
📌 Commit 345e7c3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 31, 2018
resolve: Make sure indeterminate and inconsistent macro resolutions always generate errors Addresses the issue described in #50911 (comment) I haven't come up with a minimized reproduction yet, but confirmed that `npbot` now generates the correct error with `![feature(use_extern_macros)]`.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue described in #50911 (comment)
I haven't come up with a minimized reproduction yet, but confirmed that
npbotnow generates the correct error with![feature(use_extern_macros)].