Did you mean to block nightlies on clippy? #51122

oli-obk · 2018-05-28T11:55:36Z

Discussion: https://gitter.im/rust-lang/WG-clippy?at=5b073b6597a0361fb760cdc2

r? @alexcrichton

did I forget anything?

cc @nrc @Manishearth

rust-highfive · 2018-05-28T11:55:47Z

Warning

These commits modify submodules.

kennytm · 2018-05-28T12:48:13Z

Did you really mean to block nightlies on clippy? 😏

If you want clippy to block nightlies, you need to submit a PR to rust-central-station later (like rust-lang/rust-central-station@913a3b3).
If you want clippy to block betas and stables, you need to update src/ci/docker/x86_64-gnu-tools/checktools.sh.

oli-obk · 2018-05-28T13:42:38Z

If you want clippy to block betas and stables

We'll first see how this is going

Keruspe · 2018-05-28T14:38:26Z

src/bootstrap/dist.rs

@@ -40,6 +40,8 @@ pub fn pkgname(builder: &Builder, component: &str) -> String {
    if component == "cargo" {
        format!("{}-{}", component, builder.cargo_package_vers())
    } else if component == "rls" {
+        format!("{}-{}", component, builder.clippy_package_vers())


You swapped rls and clippy here

Thanks! Copy paste at its worst

bors · 2018-05-28T14:54:52Z

☔ The latest upstream changes (presumably #51118) made this pull request unmergeable. Please resolve the merge conflicts.

nrc · 2018-05-29T01:18:55Z

To clarify, I meant that I think we should do this in a few weeks once we have collected some data about Clippy tests failing and had a discussion with the dev-tools and core teams.

oli-obk · 2018-05-29T05:31:07Z

Oh... I understood that there had been this discussion and we should do this change in order to collect said data.

Apropos, this PR does not actually block nightlies on clippy, it just ships the clippy-driver binary. With a tiny change I can make this PR not produce a component. If we then merge this PR we'll have much easier time in adding clippy later.

So... how do we collect that data? Do I just give you a histogram of number of hours from clippy breaking to clippy releasing a new version? Or do you want the opposite? A histogram for how long clippy actually works? Because we have this data in some form iin the clippy repo.

oli-obk · 2018-05-29T10:45:52Z

I just talked with @Manishearth about this. Here's what I got out of that discussion:

The data we have is that usually clippy breaks around once every two weeks. Sometimes though we get 3-4 days where it breaks every day, and then there's a period where it works for a while.
We don't often fix clippy ahead of time (before a nightly hits that actually breaks clippy), because there's little use in doing so. If nightlies were blocked on clippy, we'd fix clippy and update the submodule immediately when it's broken (the fixes in the last few months were trivial renamings and some restructurings, nothing where clippy has to figure out a new way to do something)
cc @rust-lang/infra would it make sense to speed up merging submodule-only changes by taking the binaries of the previously merged PR and just testing the changed submodules?

Manishearth · 2018-05-29T10:48:28Z

We probably should get accurate data on this, fwiw, this is what I've seen from rough measurements.

…

On Tue, May 29, 2018, 12:46 PM Oliver Schneider ***@***.***> wrote: I just talked with @Manishearth <https://github.com/Manishearth> about this. Here's what I got out of that discussion: 1. The data we have is that usually clippy breaks around once every two weeks. Sometimes though we get 3-4 days where it breaks every day, and then there's a period where it works for a while. 2. We don't often fix clippy ahead of time (before a nightly hits that actually breaks clippy), because there's little use in doing so. If nightlies were blocked on clippy, we'd fix clippy and update the submodule immediately when it's broken (the fixes in the last few months were trivial renamings and some restructurings, nothing where clippy has to figure out a new way to do something) 3. cc @rust-lang/infra <https://github.com/orgs/rust-lang/teams/infra> would it make sense to speed up merging submodule-only changes by taking the binaries of the previously merged PR and just testing the changed submodules? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51122 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABivSHxhdKpennWDLcTYPFieLgR4qdX5ks5t3ScLgaJpZM4UQFUM> .

oli-obk · 2018-05-29T11:10:39Z

I generated a diagram from our CHANGELOG.md:

X is the number of days between clippy versions. The same diagram for just 2018 is

So it seems that the majority of no breakage happening is in the 3-5 day range

Note that this data is obviously wrong, because if we don't release a new version quickly, the number of days between releases goes up, even if the breakage happens after fewer days.
Another reason this data is wrong is due to the fact that as long as rls is broken, we're not getting new nightlies, and thus clippy isn't breaking.

kennytm · 2018-05-29T13:02:26Z

@oli-obk

I'm not sure if it's worth it. The main difficulty is determine what is meant by "submodule-only changes", since often you also need to update Cargo.lock, and that may change the behavior of the rest of rustc.

alexcrichton · 2018-05-29T16:49:27Z

r? @nrc

shepmaster · 2018-06-02T16:20:07Z

Ping from triage, @nrc !

nrc · 2018-06-04T01:38:52Z

Nominating for discussion in this weeks meeting

Manishearth · 2018-06-05T20:42:56Z

We discussed this today's meeting, we'd like to merge this, without blocking nightlies (just adding a component). Hopefully we can move to a component based model for clippy from here, and eventually block nightlies. The Rustup support for this exists but may not be perfectly tested, so we may have some stuff to fix here.

One thing we also discussed was the data. It seems like one of the problems is that if clippy breaks nightly, it takes long enough to fix it that other breakages end up entering the queue. For this, we should:

p=100 component update PRs
Use https://github.com/kennytm/rustup-toolchain-install-master so we don't have to build rustc
Probably maintain a temporary branch on clippy and avoid doing releases.

r? @kennytm on the toolchain code?

kennytm

LGTM except one item, but cc @Mark-Simulacrum for double-checking.

kennytm · 2018-06-05T21:18:50Z

src/bootstrap/dist.rs

+        let doc = image.join("share/doc/clippy");
+        builder.install(&src.join("README.md"), &doc, 0o644);
+        builder.install(&src.join("LICENSE-MIT"), &doc, 0o644);
+        builder.install(&src.join("LICENSE-APACHE"), &doc, 0o644);


Clippy doesn't have LICENSE-MIT + LICENSE-APACHE, it only has a LICENSE file.

This still needs to be fixed.

o01eg · 2018-06-06T17:03:42Z

Could you mention in config.toml.example that clippy is available in build.tools array?

oli-obk · 2018-06-07T10:56:30Z

r? @Mark-Simulacrum

bors · 2018-07-02T10:32:17Z

⌛ Testing commit 6d11439 with merge 83608dbab1d5e1eab6f59a8486d8c4e3fe4e4274...

oli-obk · 2018-07-02T11:58:40Z

@bors r-

I only updated the LICENSE file mess for clippy docs, not clippy itself

oli-obk · 2018-07-02T12:59:28Z

@bors r+

passes locally now

bors · 2018-07-02T12:59:29Z

📌 Commit 78adefd has been approved by oli-obk

oli-obk · 2018-07-02T12:59:41Z

@bors r=Mark-Simulacrum

bors · 2018-07-02T12:59:42Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Raise an error if gcov profiling and incremental compilation are both enabled #51645

bors · 2018-07-02T12:59:43Z

📌 Commit 78adefd has been approved by Mark-Simulacrum

bors · 2018-07-02T14:04:32Z

⌛ Testing commit 78adefd with merge 4faaf7e...

@alexcrichton

Did you mean to block nightlies on clippy? Discussion: https://gitter.im/rust-lang/WG-clippy?at=5b073b6597a0361fb760cdc2 r? @alexcrichton did I forget anything? cc @nrc @Manishearth

bors · 2018-07-02T16:04:49Z

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 4faaf7e to master...

oli-obk · 2018-07-02T16:06:25Z

No trumpets? Clippy appears still broken, it worked locally :/ Maybe another change jumped in

o01eg · 2018-07-17T10:02:34Z

Was it forgotten to add clippy to Kind::Install in builder.rs?

Allow clippy to be installed with make install After rust-lang#51122 clippy is available as a component but doesn't install when building from source. This PR allows to install clippy with extended tools.

Version 1.29.0 (2018-09-13) ========================== Compiler -------- - [Bumped minimum LLVM version to 5.0.][51899] - [Added `powerpc64le-unknown-linux-musl` target.][51619] - [Added `aarch64-unknown-hermit` and `x86_64-unknown-hermit` targets.][52861] Libraries --------- - [`Once::call_once` now no longer requires `Once` to be `'static`.][52239] - [`BuildHasherDefault` now implements `PartialEq` and `Eq`.][52402] - [`Box<CStr>`, `Box<OsStr>`, and `Box<Path>` now implement `Clone`.][51912] - [Implemented `PartialEq<&str>` for `OsString` and `PartialEq<OsString>` for `&str`.][51178] - [`Cell<T>` now allows `T` to be unsized.][50494] - [`SocketAddr` is now stable on Redox.][52656] Stabilized APIs --------------- - [`Arc::downcast`] - [`Iterator::flatten`] - [`Rc::downcast`] Cargo ----- - [Cargo can silently fix some bad lockfiles ][cargo/5831] You can use `--locked` to disable this behaviour. - [`cargo-install` will now allow you to cross compile an install using `--target`][cargo/5614] - [Added the `cargo-fix` subcommand to automatically move project code from 2015 edition to 2018.][cargo/5723] Misc ---- - [`rustdoc` now has the `--cap-lints` option which demotes all lints above the specified level to that level.][52354] For example `--cap-lints warn` will demote `deny` and `forbid` lints to `warn`. - [`rustc` and `rustdoc` will now have the exit code of `1` if compilation fails, and `101` if there is a panic.][52197] - [A preview of clippy has been made available through rustup.][51122] You can install the preview with `rustup component add clippy-preview` Compatibility Notes ------------------- - [`str::{slice_unchecked, slice_unchecked_mut}` are now deprecated.][51807] Use `str::get_unchecked(begin..end)` instead. - [`std::env::home_dir` is now deprecated for its unintuitive behaviour.][51656] Consider using the `home_dir` function from https://crates.io/crates/dirs instead. - [`rustc` will no longer silently ignore invalid data in target spec.][52330] [52861]: rust-lang/rust#52861 [52656]: rust-lang/rust#52656 [52239]: rust-lang/rust#52239 [52330]: rust-lang/rust#52330 [52354]: rust-lang/rust#52354 [52402]: rust-lang/rust#52402 [52103]: rust-lang/rust#52103 [52197]: rust-lang/rust#52197 [51807]: rust-lang/rust#51807 [51899]: rust-lang/rust#51899 [51912]: rust-lang/rust#51912 [51511]: rust-lang/rust#51511 [51619]: rust-lang/rust#51619 [51656]: rust-lang/rust#51656 [51178]: rust-lang/rust#51178 [51122]: rust-lang/rust#51122 [50494]: rust-lang/rust#50494 [cargo/5614]: rust-lang/cargo#5614 [cargo/5723]: rust-lang/cargo#5723 [cargo/5831]: rust-lang/cargo#5831 [`Arc::downcast`]: https://doc.rust-lang.org/std/sync/struct.Arc.html#method.downcast [`Iterator::flatten`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.flatten [`Rc::downcast`]: https://doc.rust-lang.org/std/rc/struct.Rc.html#method.downcast

Add Clippy to config.toml.example Omitted in rust-lang#51122 The order is based on https://github.com/rust-lang/rust/blob/ec194646fef1a467073ad74b8b68f6f202cfce97/src/bootstrap/install.rs#L212

rust-highfive assigned alexcrichton May 28, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2018

kennytm added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label May 28, 2018

Keruspe reviewed May 28, 2018

View reviewed changes

oli-obk force-pushed the clippy branch from e9fa4a9 to e148cf0 Compare May 28, 2018 20:07

rust-highfive assigned nrc and unassigned alexcrichton May 29, 2018

kennytm added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label May 29, 2018

nrc added the I-nominated label Jun 4, 2018

rust-highfive assigned kennytm and unassigned nrc Jun 5, 2018

kennytm reviewed Jun 5, 2018

View reviewed changes

oli-obk force-pushed the clippy branch from e148cf0 to fd9c2f5 Compare June 6, 2018 15:40

rust-highfive unassigned kennytm Jun 7, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2018

Clippy tool also has only a single LICENSE file

78adefd

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 2, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2018

bors merged commit 78adefd into rust-lang:master Jul 2, 2018

oli-obk deleted the clippy branch July 2, 2018 16:06

bors mentioned this pull request Jul 2, 2018

bootstrap: tests should use rustc from config.toml #51977

Merged

mati865 mentioned this pull request Jul 5, 2018

Tracking issue for tools build error: duplicate artfacts found when compiling a tool #52072

Closed

o01eg mentioned this pull request Jul 17, 2018

Allow clippy to be installed with make install #52464

Merged

mati865 mentioned this pull request Jan 2, 2019

Add Clippy to config.toml.example #57278

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Did you mean to block nightlies on clippy? #51122

Did you mean to block nightlies on clippy? #51122

oli-obk commented May 28, 2018

rust-highfive commented May 28, 2018

kennytm commented May 28, 2018

oli-obk commented May 28, 2018

Keruspe May 28, 2018

oli-obk May 28, 2018 •

edited

Loading

bors commented May 28, 2018

nrc commented May 29, 2018

oli-obk commented May 29, 2018

oli-obk commented May 29, 2018

Manishearth commented May 29, 2018 via email

oli-obk commented May 29, 2018

kennytm commented May 29, 2018

alexcrichton commented May 29, 2018

shepmaster commented Jun 2, 2018

nrc commented Jun 4, 2018

Manishearth commented Jun 5, 2018 •

edited

Loading

kennytm left a comment

kennytm Jun 5, 2018

Mark-Simulacrum Jun 12, 2018

o01eg commented Jun 6, 2018

oli-obk commented Jun 7, 2018

bors commented Jul 2, 2018

oli-obk commented Jul 2, 2018

oli-obk commented Jul 2, 2018

bors commented Jul 2, 2018

oli-obk commented Jul 2, 2018

bors commented Jul 2, 2018

bors commented Jul 2, 2018

bors commented Jul 2, 2018

bors commented Jul 2, 2018

oli-obk commented Jul 2, 2018

o01eg commented Jul 17, 2018

Did you mean to block nightlies on clippy? #51122

Did you mean to block nightlies on clippy? #51122

Conversation

oli-obk commented May 28, 2018

rust-highfive commented May 28, 2018

kennytm commented May 28, 2018

oli-obk commented May 28, 2018

Keruspe May 28, 2018

Choose a reason for hiding this comment

oli-obk May 28, 2018 • edited Loading

Choose a reason for hiding this comment

bors commented May 28, 2018

nrc commented May 29, 2018

oli-obk commented May 29, 2018

oli-obk commented May 29, 2018

Manishearth commented May 29, 2018 via email

oli-obk commented May 29, 2018

kennytm commented May 29, 2018

alexcrichton commented May 29, 2018

shepmaster commented Jun 2, 2018

nrc commented Jun 4, 2018

Manishearth commented Jun 5, 2018 • edited Loading

kennytm left a comment

Choose a reason for hiding this comment

kennytm Jun 5, 2018

Choose a reason for hiding this comment

Mark-Simulacrum Jun 12, 2018

Choose a reason for hiding this comment

o01eg commented Jun 6, 2018

oli-obk commented Jun 7, 2018

bors commented Jul 2, 2018

oli-obk commented Jul 2, 2018

oli-obk commented Jul 2, 2018

bors commented Jul 2, 2018

oli-obk commented Jul 2, 2018

bors commented Jul 2, 2018

bors commented Jul 2, 2018

bors commented Jul 2, 2018

bors commented Jul 2, 2018

oli-obk commented Jul 2, 2018

o01eg commented Jul 17, 2018

oli-obk May 28, 2018 •

edited

Loading

Manishearth commented Jun 5, 2018 •

edited

Loading