Register outlives predicates from queries the right way around. #51096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
May 30, 2018
| Constraint::VarSubVar(v1, v2) => ty::OutlivesPredicate( | ||
| tcx.mk_region(ty::ReVar(v1)).into(), | ||
| tcx.mk_region(ty::ReVar(v2)), | ||
| tcx.mk_region(ty::ReVar(v2)).into(), |
There was a problem hiding this comment.
woah, this is .. indeed wrong. Sigh.
|
@bors r+ |
|
📌 Commit 9582507 has been approved by |
bors
added
S-waiting-on-bors
|
🔒 Merge conflict |
bors
added
S-waiting-on-author
|
@bors delegate=matthewjasper @matthewjasper, when you get a chance to rebase, feel free to tell bors "r=nikomatsakis" |
|
✌️ @matthewjasper can now approve this pull request |
matthewjasper
force-pushed
the
reverse-normalization-bounds
branch
from
9582507 to
b83daea
Compare
|
rebased |
|
@bors r+ |
|
📌 Commit b83daea has been approved by |
bors
added
S-waiting-on-bors
|
@bors r=nikomatsakis |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b83daea has been approved by |
bors
added a commit
that referenced
this pull request
May 31, 2018
…nikomatsakis Register outlives predicates from queries the right way around. Closes #49354 The region constraints from queries need to be reversed from sub to outlives. Note: wf checking reports these errors before NLL, so I'm not sure if there's any case when these predicates need to be created at all. cc @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49354
The region constraints from queries need to be reversed from sub to outlives.
Note: wf checking reports these errors before NLL, so I'm not sure if there's any case when these predicates need to be created at all.
cc @nikomatsakis