Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AllFacts from polonius-engine #51047

Merged
merged 1 commit into from
May 26, 2018
Merged

Use AllFacts from polonius-engine #51047

merged 1 commit into from
May 26, 2018
+82 −26

Conversation

spastorino
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2018
@spastorino spastorino requested a review from nikomatsakis May 24, 2018 21:54
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:02:50]  Downloading strsim v0.7.0
[00:02:50]  Downloading byteorder v1.2.2
[00:02:50]  Downloading log_settings v0.1.1
[00:02:51]  Downloading log v0.4.1
[00:02:51]  Downloading polonius-engine v0.1.1
[00:02:52]  Downloading phf_shared v0.7.21
[00:02:52]  Downloading string_cache_shared v0.3.0
[00:02:52]  Downloading phf_generator v0.7.21
[00:02:52]  Downloading flate2 v1.0.1
---
tidy check
[00:05:06] * 547 error codes
[00:05:06] * highest error code: E0911
[00:05:06] * 204 features
[00:05:07] Dependencies not on the whitelist:
[00:05:07] * polonius-engine 
[00:05:07] some tidy checks failed
[00:05:07] 
[00:05:07] 
[00:05:07] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:07] 
[00:05:07] 
[00:05:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:07] Build completed unsuccessfully in 0:01:58
[00:05:07] Build completed unsuccessfully in 0:01:58
[00:05:07] Makefile:79: recipe for target 'tidy' failed
[00:05:07] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:083e6c6b
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nikomatsakis
Copy link
Contributor

@spastorino you have to add the crate to the whitelist

@spastorino spastorino force-pushed the use_polonius_engine_facts branch from e66479d to 8429d11 Compare May 24, 2018 22:56
@nikomatsakis
Copy link
Contributor

@bors delegate=spastorino

r=me once travis is happy

@bors
Copy link
Contributor

bors commented May 24, 2018

✌️ @spastorino can now approve this pull request

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 25, 2018

📌 Commit 8429d11 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2018
@KiChjang
Copy link
Member

🐸

kennytm added a commit to kennytm/rust that referenced this pull request May 26, 2018
@kennytm
Rollup merge of rust-lang#51047 - spastorino:use_polonius_engine_fact…
e667e7b 
…s, r=nikomatsakis

Use AllFacts from polonius-engine
@kennytm kennytm mentioned this pull request May 26, 2018
Merged
bors added a commit that referenced this pull request May 26, 2018
@bors
Auto merge of #51082 - kennytm:rollup, r=kennytm
7a0e6a8 
Rollup of 11 pull requests

Successful merges:

 - #50987 (Underline multiple suggested replacements in the same line)
 - #51014 (Add documentation about env! second argument)
 - #51034 (Remove unused lowering field and method)
 - #51047 (Use AllFacts from polonius-engine)
 - #51048 (Add more missing examples for Formatter)
 - #51056 (Mention and use `Once::new` instead of `ONCE_INIT`)
 - #51059 (What does an expression look like, that consists only of special characters?)
 - #51065 (Update nomicon link in transmute docs)
 - #51067 (Add inner links in documentation)
 - #51070 (Fail typecheck if we encounter a bogus break)
 - #51073 (Rename TokenStream::empty to TokenStream::new)

Failed merges:
@bors bors merged commit 8429d11 into rust-lang:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spastorino @rust-highfive @nikomatsakis @bors @KiChjang @estebank