Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing error codes in libsyntax-ext asm #50752

Merged
merged 1 commit into from
May 17, 2018
Merged

Add missing error codes in libsyntax-ext asm #50752

merged 1 commit into from
May 17, 2018

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 

[00:06:46] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:06:46] tidy error: /checkout/src/test/ui/E0663.rs: missing trailing newline
[00:06:48] some tidy checks failed
[00:06:48] 
[00:06:48] 
[00:06:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:06:48] 
[00:06:48] 
[00:06:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:06:48] Build completed unsuccessfully in 0:02:55
[00:06:48] Build completed unsuccessfully in 0:02:55
[00:06:48] make: *** [tidy] Error 1
[00:06:48] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:24db3c38
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

r? @frewsxcv

frewsxcv
frewsxcv approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after tidy error is fixed

@frewsxcv
Copy link
Member

@bors rollup

@GuillaumeGomez GuillaumeGomez force-pushed the more-error-code-in-libsyntax-ext branch from d46e297 to 30d9502 Compare May 15, 2018 12:30
@GuillaumeGomez
Copy link
Member Author

Fixed tidy.

@kennytm
Copy link
Member

kennytm commented May 15, 2018

@bors r=frewsxcv

@bors
Copy link
Contributor

bors commented May 15, 2018

📌 Commit 30d9502 has been approved by frewsxcv

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 15, 2018
@kennytm
Rollup merge of rust-lang#50752 - GuillaumeGomez:more-error-code-in-l…
5030038 
…ibsyntax-ext, r=frewsxcv

Add missing error codes in libsyntax-ext asm
@kennytm kennytm mentioned this pull request May 15, 2018
Closed
@kennytm kennytm mentioned this pull request May 16, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request May 16, 2018
@kennytm
Rollup merge of rust-lang#50752 - GuillaumeGomez:more-error-code-in-l…
39129a5 
…ibsyntax-ext, r=frewsxcv

Add missing error codes in libsyntax-ext asm
bors added a commit that referenced this pull request May 17, 2018
@bors
Auto merge of #50807 - kennytm:rollup, r=kennytm
b559710 
Rollup of 17 pull requests

Successful merges:

 - #50170 (Implement From for more types on Cow)
 - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux)
 - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait)
 - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`)
 - #50726 (read2: Use inner function instead of closure)
 - #50728 (Fix rustdoc panic with `impl Trait` in type parameters)
 - #50736 (env: remove unwrap in examples in favor of try op)
 - #50740 (Remove LazyBTreeMap.)
 - #50752 (Add missing error codes in libsyntax-ext asm)
 - #50779 (Make mutable_noalias and arg_align_attributes be tracked)
 - #50787 (Fix run-make wasm tests)
 - #50788 (Fix an ICE when casting a nonexistent const)
 - #50789 (Ensure libraries built in stage0 have unique metadata)
 - #50793 (tidy: Add a check for empty UI test files)
 - #50797 (fix a typo in signed-integer::from_str_radix())
 - #50808 (Stabilize num::NonZeroU*)
 - #50809 (GitHub: Stop treating Cargo.lock as a generated file.)

Failed merges:
@bors bors merged commit 30d9502 into rust-lang:master May 17, 2018
@GuillaumeGomez GuillaumeGomez deleted the more-error-code-in-libsyntax-ext branch May 17, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees

@frewsxcv frewsxcv

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-highfive @alexcrichton @frewsxcv @kennytm @bors