Add inline attributes to syntax_pos #50294

Zoxc · 2018-04-28T01:18:26Z

The existing impl PartialOrd<InternedString> for InternedString causes an error in some of my branches for some reason...

rust-highfive · 2018-04-28T01:18:37Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2018-04-28T02:59:00Z

Could the #[inline(always)] be switched to #[inline]? Other than that r=me

Zoxc · 2018-04-28T05:46:51Z

@bors r=alexcrichton

bors · 2018-04-28T05:46:52Z

📌 Commit 2bc67a5 has been approved by alexcrichton

bors · 2018-04-29T05:16:08Z

⌛ Testing commit 2bc67a50de19eb4b5eed7c78f34aa965e87c474a with merge 12f841893f0e2f796b511d0cda5926d39913d056...

bors · 2018-04-29T06:30:14Z

💔 Test failed - status-travis

rust-highfive · 2018-04-29T06:30:16Z

The job x86_64-gnu-nopt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:10:31] ---- [run-pass] run-pass-fulldeps/macro-crate-multi-decorator-literals.rs stdout ----
[01:10:31]  
[01:10:31] error: compilation failed!
[01:10:31] status: exit code: 101
[01:10:31] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu" "-Crpath" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu.aux"
[01:10:31] ------------------------------------------
[01:10:31] 
[01:10:31] ------------------------------------------
[01:10:31] stderr:
---
[01:10:31]    | ^^^^^^^^^^^^
[01:10:31]    |
[01:10:31]    = note: #[warn(unused_imports)] on by default
[01:10:31] 
[01:10:31] warning: compiler plugin used as an ordinary library
[01:10:31]    |
[01:10:31] 19 | extern crate macro_crate_test;
[01:10:31]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:10:31]    |
[01:10:31]    |
[01:10:31]    = note: #[warn(plugin_as_library)] on by default
[01:10:31] 
[01:10:31] error: linking with `cc` failed: exit code: 1
[01:10:31]   |
[01:10:31]   = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals1.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals10.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals11.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals2.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals3.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals4.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals5.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals6.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals7.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals8.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals9.rcgu.o" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu.aux" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_plugin-197ac5dec2e5592f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_metadata-73a60d28dcc8d3e0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "syntax_ext-3dacfb5b3c39e1ee" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc-c6263d330d2b9f31" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "test-902559d4a0cc83d5" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "term-36880752958d2c6f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "proc_macro-c7d45a460cb3a738" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_const_math-e212b3283c198d45" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "graphviz-06bb7008d45cdff0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "fmt_macros-7fa0522df5af949a" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "arena-16294da79648b864" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "syntax-e97e6d4ccc983706" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_target-aaec33fa4a23ec51" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_errors-dafdecc781917b18" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "syntax_pos-ccbedf94f6bd555f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_data_structures-22e458fc7e0d421f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_cratesio_shim-7bdcd669c7579602" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "serialize-b63c42e100577192" "-Wl,--start-group" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "std-b63203ee1146648a" "-Wl,--end-group" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-bbf524080a1524b2.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" "-Wl,-rpath,$ORIGIN/../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-rpath,/checkout/obj/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags"
[01:10:31]   = note: /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o: In function `core::str::traits::_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$::eq::h87d16125d269f67a':
[01:10:31]           macro_crate_multi_decorator_literals0-317d481089b8c8fe83113de504472633.rs:(.text._ZN4core3str6traits54_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$2eq17h87d16125d269f67aE+0x41): undefined reference to `core::cmp::impls::_$LT$impl$u20$core..cmp..PartialEq$LT$$RF$$u27$b$u20$B$GT$$u20$for$u20$$RF$$u27$a$u20$A$GT$::eq::ha31f7d414bd1aa29'
[01:10:31]           collect2: error: ld returned 1 exit status
[01:10:31] 
[01:10:31] error: aborting due to previous error
[01:10:31] 
[01:10:31] 
---
[01:10:31] 
[01:10:31] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:488:22
[01:10:31] 
[01:10:31] 
[01:10:31] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -Zunstable-options " "--target-rustcflags" "-Crpath -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "6.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:10:31] 
[01:10:31] 
[01:10:31] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:10:31] Build completed unsuccessfully in 0:13:30
[01:10:31] Build completed unsuccessfully in 0:13:30
[01:10:31] Makefile:58: recipe for target 'check' failed
[01:10:31] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:026bd193
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-04-29T06:30:21Z

The job x86_64-gnu-nopt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:10:31] ---- [run-pass] run-pass-fulldeps/macro-crate-multi-decorator-literals.rs stdout ----
[01:10:31]  
[01:10:31] error: compilation failed!
[01:10:31] status: exit code: 101
[01:10:31] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu" "-Crpath" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu.aux"
[01:10:31] ------------------------------------------
[01:10:31] 
[01:10:31] ------------------------------------------
[01:10:31] stderr:
---
[01:10:31]    | ^^^^^^^^^^^^
[01:10:31]    |
[01:10:31]    = note: #[warn(unused_imports)] on by default
[01:10:31] 
[01:10:31] warning: compiler plugin used as an ordinary library
[01:10:31]    |
[01:10:31] 19 | extern crate macro_crate_test;
[01:10:31]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:10:31]    |
[01:10:31]    |
[01:10:31]    = note: #[warn(plugin_as_library)] on by default
[01:10:31] 
[01:10:31] error: linking with `cc` failed: exit code: 1
[01:10:31]   |
[01:10:31]   = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals1.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals10.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals11.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals2.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals3.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals4.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals5.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals6.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals7.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals8.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals9.rcgu.o" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-x86_64-unknown-linux-gnu.aux" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_plugin-197ac5dec2e5592f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_metadata-73a60d28dcc8d3e0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "syntax_ext-3dacfb5b3c39e1ee" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc-c6263d330d2b9f31" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "test-902559d4a0cc83d5" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "term-36880752958d2c6f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "proc_macro-c7d45a460cb3a738" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_const_math-e212b3283c198d45" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "graphviz-06bb7008d45cdff0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "fmt_macros-7fa0522df5af949a" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "arena-16294da79648b864" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "syntax-e97e6d4ccc983706" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_target-aaec33fa4a23ec51" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_errors-dafdecc781917b18" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "syntax_pos-ccbedf94f6bd555f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_data_structures-22e458fc7e0d421f" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "rustc_cratesio_shim-7bdcd669c7579602" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "serialize-b63c42e100577192" "-Wl,--start-group" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "std-b63203ee1146648a" "-Wl,--end-group" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-bbf524080a1524b2.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" "-Wl,-rpath,$ORIGIN/../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-rpath,/checkout/obj/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags"
[01:10:31]   = note: /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o: In function `core::str::traits::_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$::eq::h87d16125d269f67a':
[01:10:31]           macro_crate_multi_decorator_literals0-317d481089b8c8fe83113de504472633.rs:(.text._ZN4core3str6traits54_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$2eq17h87d16125d269f67aE+0x41): undefined reference to `core::cmp::impls::_$LT$impl$u20$core..cmp..PartialEq$LT$$RF$$u27$b$u20$B$GT$$u20$for$u20$$RF$$u27$a$u20$A$GT$::eq::ha31f7d414bd1aa29'
[01:10:31]           collect2: error: ld returned 1 exit status
[01:10:31] 
[01:10:31] error: aborting due to previous error
[01:10:31] 
[01:10:31] 
---
[01:10:31] 
[01:10:31] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:488:22
[01:10:31] 
[01:10:31] 
[01:10:31] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -Zunstable-options " "--target-rustcflags" "-Crpath -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "6.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:10:31] 
[01:10:31] 
[01:10:31] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:10:31] Build completed unsuccessfully in 0:13:30
[01:10:31] Build completed unsuccessfully in 0:13:30
[01:10:31] Makefile:58: recipe for target 'check' failed
[01:10:31] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:026bd193
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-05-01T20:21:39Z

@Zoxc Have you checked if the linker error in #50294 (comment) is fixed? The current diff seems to be exactly the same as the diff of 12f841893f0e2f796b511d0cda5926d39913d056.

Zoxc · 2018-05-02T01:21:36Z

I haven't changed anything (or reproduced the linker error). I've just rebased the branch.

kennytm · 2018-05-02T01:25:43Z

OK let me change it back to S-waiting-on-author then 🙂

Zoxc · 2018-05-05T10:51:58Z

I've removed the changes to InternedString since the error was caused by a dependency on the rayon crate. I'll fix it in #50235.

This just leaves the #[inline] attributes for the PR. I've looked over syntax_pos added some more of them.

alexcrichton · 2018-05-05T15:44:17Z

@bors: r+

bors · 2018-05-05T15:44:18Z

📌 Commit 7e53f41 has been approved by alexcrichton

bors · 2018-05-05T17:26:18Z

⌛ Testing commit 7e53f41 with merge 601f2eca1fc2ce6273cd6b346df45928b059dc2f...

bors · 2018-05-05T18:58:13Z

💔 Test failed - status-travis

rust-highfive · 2018-05-05T18:58:15Z

The job i686-gnu-nopt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:26:47] ---- [run-pass] run-pass-fulldeps/macro-crate-multi-decorator-literals.rs stdout ----
[01:26:47]  
[01:26:47] error: compilation failed!
[01:26:47] status: exit code: 101
[01:26:47] command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.rs" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "--target=i686-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu" "-Crpath" "-Zunstable-options" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu.aux"
[01:26:47] ------------------------------------------
[01:26:47] 
[01:26:47] ------------------------------------------
[01:26:47] stderr:
---
[01:26:47]    | ^^^^^^^^^^^^
[01:26:47]    |
[01:26:47]    = note: #[warn(unused_imports)] on by default
[01:26:47] 
[01:26:47] warning: compiler plugin used as an ordinary library
[01:26:47]    |
[01:26:47] 19 | extern crate macro_crate_test;
[01:26:47]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:26:47]    |
[01:26:47]    |
[01:26:47]    = note: #[warn(plugin_as_library)] on by default
[01:26:47] 
[01:26:47] error: linking with `cc` failed: exit code: 1
[01:26:47]   |
[01:26:47]   = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m32" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals1.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals10.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals11.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals2.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals3.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals4.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals5.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals6.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals7.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals8.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals9.rcgu.o" "-o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu.aux" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_plugin-b095cdd51f2398b7" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_metadata-5958a5d11a6d02b8" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax_ext-d61f5115024df074" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc-bb9cdae09a478538" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "test-be30e492d9d17d99" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "term-79e6104dc4106b98" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "proc_macro-ab418923d4130811" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "graphviz-425b37f3eb107a9f" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "fmt_macros-ae1eb2a98770082e" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "arena-a11d08f45d8c6283" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax-5ef387d08892ffa7" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_target-434dc93720f9df82" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_errors-0798acec4bef62ae" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax_pos-188bf7c100a2e31c" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_data_structures-fc5193a97cae01c4" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_cratesio_shim-5de3f5c2e9ed281d" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "serialize-b8b2d69c4870530f" "-Wl,--start-group" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "std-bc9c5f91b6be96a0" "-Wl,--end-group" "-Wl,-Bstatic" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libcompiler_builtins-e6756d75def20064.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" "-Wl,-rpath,$ORIGIN/../../stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-Wl,-rpath,/checkout/obj/lib/rustlib/i686-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags"
[01:26:47]   = note: /checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o: In function `core::str::traits::_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$::eq::hd698c0257184e0d2':
[01:26:47]           macro_crate_multi_decorator_literals0-317d481089b8c8fe83113de504472633.rs:(.text._ZN4core3str6traits54_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$2eq17hd698c0257184e0d2E+0x78): undefined reference to `core::cmp::impls::_$LT$impl$u20$core..cmp..PartialEq$LT$$RF$$u27$b$u20$B$GT$$u20$for$u20$$RF$$u27$a$u20$A$GT$::eq::h89a3cf1172f82e51'
[01:26:47]           collect2: error: ld returned 1 exit status
[01:26:47] 
[01:26:47] error: aborting due to previous error
[01:26:47] 
[01:26:47] 
---
[01:26:47] test result: FAILED. 87 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:26:47] 
[01:26:47] 
[01:26:47] 
[01:26:47] command did not execute successfully: "/checkout/obj/build/i686-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass-fulldeps" "--build-base" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "--stage-id" "stage2-i686-unknown-linux-gnu" "--mode" "run-pass" "--target" "i686-unknown-linux-gnu" "--host" "i686-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/i686-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -Zunstable-options " "--target-rustcflags" "-Crpath -Zunstable-options  -Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "6.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:26:47] 
[01:26:47] 
[01:26:47] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:26:47] Build completed unsuccessfully in 0:15:22
[01:26:47] Build completed unsuccessfully in 0:15:22
[01:26:47] make: *** [check] Error 1
[01:26:47] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0b170c6e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-05T18:58:25Z

The job i686-gnu-nopt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:26:47] ---- [run-pass] run-pass-fulldeps/macro-crate-multi-decorator-literals.rs stdout ----
[01:26:47]  
[01:26:47] error: compilation failed!
[01:26:47] status: exit code: 101
[01:26:47] command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.rs" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "--target=i686-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu" "-Crpath" "-Zunstable-options" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu.aux"
[01:26:47] ------------------------------------------
[01:26:47] 
[01:26:47] ------------------------------------------
[01:26:47] stderr:
---
[01:26:47]    | ^^^^^^^^^^^^
[01:26:47]    |
[01:26:47]    = note: #[warn(unused_imports)] on by default
[01:26:47] 
[01:26:47] warning: compiler plugin used as an ordinary library
[01:26:47]    |
[01:26:47] 19 | extern crate macro_crate_test;
[01:26:47]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:26:47]    |
[01:26:47]    |
[01:26:47]    = note: #[warn(plugin_as_library)] on by default
[01:26:47] 
[01:26:47] error: linking with `cc` failed: exit code: 1
[01:26:47]   |
[01:26:47]   = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m32" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals1.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals10.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals11.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals2.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals3.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals4.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals5.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals6.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals7.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals8.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals9.rcgu.o" "-o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu.aux" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_plugin-b095cdd51f2398b7" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_metadata-5958a5d11a6d02b8" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax_ext-d61f5115024df074" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc-bb9cdae09a478538" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "test-be30e492d9d17d99" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "term-79e6104dc4106b98" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "proc_macro-ab418923d4130811" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "graphviz-425b37f3eb107a9f" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "fmt_macros-ae1eb2a98770082e" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "arena-a11d08f45d8c6283" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax-5ef387d08892ffa7" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_target-434dc93720f9df82" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_errors-0798acec4bef62ae" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax_pos-188bf7c100a2e31c" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_data_structures-fc5193a97cae01c4" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_cratesio_shim-5de3f5c2e9ed281d" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "serialize-b8b2d69c4870530f" "-Wl,--start-group" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "std-bc9c5f91b6be96a0" "-Wl,--end-group" "-Wl,-Bstatic" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libcompiler_builtins-e6756d75def20064.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" "-Wl,-rpath,$ORIGIN/../../stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-Wl,-rpath,/checkout/obj/lib/rustlib/i686-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags"
[01:26:47]   = note: /checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o: In function `core::str::traits::_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$::eq::hd698c0257184e0d2':
[01:26:47]           macro_crate_multi_decorator_literals0-317d481089b8c8fe83113de504472633.rs:(.text._ZN4core3str6traits54_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$2eq17hd698c0257184e0d2E+0x78): undefined reference to `core::cmp::impls::_$LT$impl$u20$core..cmp..PartialEq$LT$$RF$$u27$b$u20$B$GT$$u20$for$u20$$RF$$u27$a$u20$A$GT$::eq::h89a3cf1172f82e51'
[01:26:47]           collect2: error: ld returned 1 exit status
[01:26:47] 
[01:26:47] error: aborting due to previous error
[01:26:47] 
[01:26:47] 
---
[01:26:47] test result: FAILED. 87 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:26:47] 
[01:26:47] 
[01:26:47] 
[01:26:47] command did not execute successfully: "/checkout/obj/build/i686-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass-fulldeps" "--build-base" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "--stage-id" "stage2-i686-unknown-linux-gnu" "--mode" "run-pass" "--target" "i686-unknown-linux-gnu" "--host" "i686-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/i686-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -Zunstable-options " "--target-rustcflags" "-Crpath -Zunstable-options  -Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "6.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:26:47] 
[01:26:47] 
[01:26:47] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:26:47] Build completed unsuccessfully in 0:15:22
[01:26:47] Build completed unsuccessfully in 0:15:22
[01:26:47] make: *** [check] Error 1
[01:26:47] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0b170c6e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive assigned alexcrichton Apr 28, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2018

Zoxc force-pushed the str-fix branch from bb534df to 2bc67a5 Compare April 28, 2018 04:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2018

Zoxc force-pushed the str-fix branch from 2bc67a5 to dd0b701 Compare April 30, 2018 03:26

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2018

Zoxc force-pushed the str-fix branch from dd0b701 to d42805e Compare May 5, 2018 10:36

Zoxc changed the title ~~Fix a bug with InternedString and add inline attributes to symbol.rs~~ Add inline attributes to symbol.rs May 5, 2018

Add inline attributes to syntax_pos

7e53f41

Zoxc force-pushed the str-fix branch from d42805e to 7e53f41 Compare May 5, 2018 10:50

Zoxc changed the title ~~Add inline attributes to symbol.rs~~ Add inline attributes to syntax_pos May 5, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2018

Zoxc closed this May 10, 2018

Zoxc mentioned this pull request May 10, 2018

Adding #[inline] attribute causes error #50616

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add inline attributes to syntax_pos #50294

Add inline attributes to syntax_pos #50294

Zoxc commented Apr 28, 2018

rust-highfive commented Apr 28, 2018

alexcrichton commented Apr 28, 2018

Zoxc commented Apr 28, 2018

bors commented Apr 28, 2018

bors commented Apr 29, 2018

bors commented Apr 29, 2018

rust-highfive commented Apr 29, 2018

rust-highfive commented Apr 29, 2018

kennytm commented May 1, 2018

Zoxc commented May 2, 2018

kennytm commented May 2, 2018

Zoxc commented May 5, 2018

alexcrichton commented May 5, 2018

bors commented May 5, 2018

bors commented May 5, 2018

bors commented May 5, 2018

rust-highfive commented May 5, 2018

rust-highfive commented May 5, 2018

Add inline attributes to syntax_pos #50294

Add inline attributes to syntax_pos #50294

Conversation

Zoxc commented Apr 28, 2018

rust-highfive commented Apr 28, 2018

alexcrichton commented Apr 28, 2018

Zoxc commented Apr 28, 2018

bors commented Apr 28, 2018

bors commented Apr 29, 2018

bors commented Apr 29, 2018

rust-highfive commented Apr 29, 2018

rust-highfive commented Apr 29, 2018

kennytm commented May 1, 2018

Zoxc commented May 2, 2018

kennytm commented May 2, 2018

Zoxc commented May 5, 2018

alexcrichton commented May 5, 2018

bors commented May 5, 2018

bors commented May 5, 2018

bors commented May 5, 2018

rust-highfive commented May 5, 2018

rust-highfive commented May 5, 2018