Use enum for approximate suggestions #50204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
zackmdavis
reviewed
Apr 25, 2018
src/librustc_errors/lib.rs
Outdated
| @@ -56,6 +56,14 @@ mod lock; | |||
|
|
|||
| use syntax_pos::{BytePos, Loc, FileLinesResult, FileMap, FileName, MultiSpan, Span, NO_EXPANSION}; | |||
|
|
|||
| #[derive(Copy, Clone, Debug, PartialEq, Hash, RustcEncodable, RustcDecodable)] | |||
| pub enum SuggestionApproximate { | |||
There was a problem hiding this comment.
I feel like this should have a different name given that it seems to include non-approximate (MachineApplicable) suggestions. SuggestionDefiniteness?
There was a problem hiding this comment.
I see what you mean. My first suggestion would've been SuggestionApplicability, though. (Let the bikeshedding begin)
|
@bors r+ |
|
📌 Commit 4e2cd41 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 30, 2018
Use enum for approximate suggestions r? @nrc @killercup
|
☀️ Test successful - status-appveyor, status-travis |
kennytm-githubbot
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 30, 2018
Tested on commit rust-lang/rust@9ff8ec8. Direct link to PR: <rust-lang/rust#50204> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk).
zackmdavis
added a commit
to zackmdavis/rust
that referenced
this pull request
May 20, 2018
Consider this a down payment on rust-lang#50723. To recap, an `Applicability` enum was recently (rust-lang#50204) added, to convey to Rustfix and other tools whether we think it's OK for them to blindly apply the suggestion, or whether to prompt a human for guidance (because the suggestion might contain placeholders that we can't infer, or because we think it has a sufficiently high probability of being wrong even though it's— presumably—right often enough to be worth emitting in the first place). When a suggestion is marked as `MaybeIncorrect`, we try to use comments to indicate precisely why (although there are a few places where we just say `// speculative` because the present author's subjective judgement balked at the idea that the suggestion has no false positives). The `run-rustfix` directive is opporunistically set on some relevant UI tests (and a couple tests that were in the `test/ui/suggestions` directory, even if the suggestions didn't originate in librustc or libsyntax). This is less trivial than it sounds, because a surprising number of test files aren't equipped to be tested as fixed even when they contain successfully fixable errors, because, e.g., there are more, not-directly-related errors after fixing. Some test files need an attribute or underscore to avoid unused warnings tripping up the "fixed code is still producing diagnostics" check despite the fixes being correct; this is an interesting contrast-to/inconsistency-with the behavior of UI tests (which secretly pass `-A unused`), a behavior which we probably ought to resolve one way or the other (filed issue rust-lang#50926). A few suggestion labels are reworded (e.g., to avoid phrasing it as a question, which which is discouraged by the style guidelines listed in `.span_suggestion`'s doc-comment).
zackmdavis
added a commit
to zackmdavis/rust
that referenced
this pull request
Aug 27, 2018
Looks like we forgot about this analogue of the other `_with_applicability` methods (first introduced in rust-lang#50204)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nrc @killercup