Edition breakage lint for absolute paths starting with modules #50100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2018
Manishearth
force-pushed
the
edition-path-lint
branch
from
9d52b0e
to
b28239d
Compare
This comment has been minimized.
This comment has been minimized.
Manishearth
force-pushed
the
edition-path-lint
branch
from
b28239d
to
57aa34a
Compare
This comment has been minimized.
This comment has been minimized.
Manishearth
force-pushed
the
edition-path-lint
branch
from
57aa34a
to
0aba0d1
Compare
pietroalbini
added
the
S-waiting-on-review
src/librustc/lint/builtin.rs
Outdated
| @@ -254,6 +254,13 @@ declare_lint! { | |||
| "suggest using `dyn Trait` for trait objects" | |||
| } | |||
|
|
|||
| declare_lint! { | |||
| pub FULLY_QUALIFIED_PATH_WITH_MODULE, | |||
There was a problem hiding this comment.
"Fully qualified" is <Type as Trait>::AssocItem, ::a::b::c is "absolute", that's why the feature is called extern_absolute_paths.
Manishearth
force-pushed
the
edition-path-lint
branch
3 times, most recently
from
f222c66
to
02ffcea
Compare
Manishearth
changed the title
Manishearth
force-pushed
the
edition-path-lint
branch
4 times, most recently
from
27dea94
to
f6884e6
Compare
Manishearth
force-pushed
the
edition-path-lint
branch
from
f6884e6
to
2a5ce10
Compare
Manishearth
changed the title
|
Added test. Ready for review. I also discovered that |
Manishearth
force-pushed
the
edition-path-lint
branch
from
5ba38f5
to
2a5ce10
Compare
|
Ping from triage @nikomatsakis ! This PR needs your review. |
nikomatsakis
approved these changes
Apr 24, 2018
|
@bors r+ |
|
📌 Commit 2a5ce10 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 2a5ce10 with merge 923031274149b1f0c10f00ce19e60903ac8c8079... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: retry
* crates.io was down
…On Tue, Apr 24, 2018 at 7:48 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.7130>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#50100 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AaPN0O2MAFBMKFRssBN_Tp9SNVrl14svks5tr8fbgaJpZM4Tcy_->
.
--
You received this message because you are subscribed to the Google Groups
"rust-ops" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to ***@***.***
To post to this group, send email to ***@***.***
To view this discussion on the web visit https://groups.google.com/d/
msgid/rust-ops/rust-lang/rust/pull/50100/c384125002%40github.com
<https://groups.google.com/d/msgid/rust-ops/rust-lang/rust/pull/50100/c384125002%40github.com?utm_medium=email&utm_source=footer>
.
For more options, visit https://groups.google.com/d/optout.
|
|
@nagbot-rs: 🔑 Insufficient privileges: not in try users |
|
@bors: retry |
bors
added
S-waiting-on-bors
|
@bors: p=1 trying to land edition-related changes |
bors
added a commit
that referenced
this pull request
Apr 25, 2018
Edition breakage lint for absolute paths starting with modules We plan to enable `extern_absolute_paths` in the 2018 edition. To allow for that, folks must transition their paths in a previous edition to the new one. This makes paths which import module contents via `use module::` or `::module::` obsolete, and we must edition-lint these. https://internals.rust-lang.org/t/the-great-module-adventure-continues/6678/205?u=manishearth is the current plan for paths. r? @nikomatsakis Fixes #48722
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to enable
extern_absolute_pathsin the 2018 edition. To allow for that, folks must transition their paths in a previous edition to the new one. This makes paths which import module contents viause module::or::module::obsolete, and we must edition-lint these.https://internals.rust-lang.org/t/the-great-module-adventure-continues/6678/205?u=manishearth is the current plan for paths.
r? @nikomatsakis
Fixes #48722