Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Option::filter. #49575

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Conversation

tmccombs
Copy link
Contributor

@tmccombs tmccombs commented Apr 2, 2018

Fixes #45860

@pietroalbini pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. relnotes Marks issues that should be documented in the release notes of the next release. labels Apr 2, 2018
@frewsxcv
Copy link
Member

frewsxcv commented Apr 5, 2018

there a couple other instances of the feature flag that can be removed:

https://github.com/rust-lang/rust/search?utf8=%E2%9C%93&q=option_filter&type=

@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 5, 2018
@pietroalbini
Copy link
Member

Ping from triage @withoutboats! This PR needs your review.

@withoutboats
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2018

📌 Commit c7ac32a has been approved by withoutboats

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2018
@kennytm
Copy link
Member

kennytm commented Apr 10, 2018

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Apr 11, 2018
bors added a commit that referenced this pull request Apr 11, 2018
Rollup of 14 pull requests

Successful merges:

 - #49525 (Use sort_by_cached_key where appropriate)
 - #49575 (Stabilize `Option::filter`.)
 - #49614 (in which the non-shorthand patterns lint keeps its own counsel in macros)
 - #49665 (Small nits to make couple of tests pass on mips targets.)
 - #49781 (add regression test for #16223 (NLL): use of collaterally moved value)
 - #49795 (Properly look for uninhabitedness of variants in niche-filling check)
 - #49809 (Stop emitting color codes on TERM=dumb)
 - #49856 (Do not uppercase-lint #[no_mangle] statics)
 - #49863 (fixed typo)
 - #49857 (Fix "fp" target feature for AArch64)
 - #49849 (Add --enable-debug flag to musl CI build script)
 - #49734 (proc_macro: Generalize `FromIterator` impl)
 - #49730 (Fix ICE with impl Trait)
 - #48270 (Replace `structurally_resolved_type` in casts check.)

Failed merges:
@bors bors merged commit c7ac32a into rust-lang:master Apr 12, 2018
@tmccombs tmccombs deleted the option-filter-stabilize branch August 16, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants