-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tcx in item_body_nested_bodies #49386
Conversation
Can you remove the backtrace and rename the PR to talk about the actual change? |
Well, the final goal of this PR was the original title. But changed it anyway. |
Ping from triage, @eddyb ! Looks like there's new commits to review! |
@bors r+ I took the liberty of moving the backtrace in the PR description to this comment: So it fixes the initial bug but we now get a wonderful panic:
|
📌 Commit ebbe0c2 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Yes, so it's not fully fixed. The issue is just "moved". |
Nominating for backport. The issue mentioned in the PR description is present in beta and stable, and the fix is small enough that backporting shouldn't be a big issue. |
It's not fixing the issue. It's just fixing a part of the issue. You still can't have rustdoc working with |
Fixes #47391.
r? @eddyb