Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update books for next release #49318

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Conversation

steveklabnik
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2018
@petrochenkov
Copy link
Contributor

@steveklabnik
#48516 got into the next release, but rust-lang/reference#259 is still not merged.

@kennytm
Copy link
Member

kennytm commented Mar 24, 2018

Lots of broken links.

[01:20:47] reference/special-types-and-traits.html:143: broken link fragment `#associated-functions-and-methods` pointing to `reference/items/traits.html`
[01:20:47] reference/lifetime-elision.html:137: broken link fragment `#function-pointers` pointing to `reference/types.html`
[01:20:47] reference/lifetime-elision.html:240: broken link fragment `#constant-items` pointing to `reference/items.html`
[01:20:47] reference/lifetime-elision.html:240: broken link fragment `#static-items` pointing to `reference/items.html`
[01:20:47] reference/types.html:631: broken link fragment `#elision-and-defaults-in-trait-objects` pointing to `reference/lifetime-elision.html`
[01:20:47] reference/items/constant-items.html:147: broken link - reference/items/lifetime-elision.html
[01:20:47] reference/expressions/operator-expr.html:138: broken link fragment `#the--operator` pointing to `reference/expressions/operator-expr.html`
[01:20:47] reference/expressions/match-expr.html:257: broken link - reference/range-expr.html
[01:20:47] reference/macros-by-example.html:154: broken link - reference/keyword.html
[01:20:47] reference/print.html:1059: broken link - reference/keyword.html
[01:20:47] reference/print.html:1921: broken link - reference/items/lifetime-elision.html
[01:20:47] reference/print.html:3641: broken link fragment `#the--operator` pointing to `reference/print.html`
[01:20:47] reference/print.html:5043: broken link - reference/range-expr.html
[01:20:47] reference/print.html:5586: broken link fragment `#elision-and-defaults-in-trait-objects` pointing to `reference/lifetime-elision.html`
[01:20:47] reference/print.html:6202: broken link fragment `#function-pointers` pointing to `reference/types.html`
[01:20:47] reference/print.html:6305: broken link fragment `#constant-items` pointing to `reference/items.html`
[01:20:47] reference/print.html:6305: broken link fragment `#static-items` pointing to `reference/items.html`
[01:20:47] reference/print.html:6351: broken link fragment `#associated-functions-and-methods` pointing to `reference/items/traits.html`
[01:20:49] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:20:49] note: Run with `RUST_BACKTRACE=1` for a backtrace.

@steveklabnik
Copy link
Member Author

steveklabnik commented Mar 24, 2018 via email

@steveklabnik
Copy link
Member Author

Locally, this claims to have built. Let's see what travis says.

@kennytm
Copy link
Member

kennytm commented Mar 24, 2018

@bors r+ rollup

Travis passed.

@bors
Copy link
Contributor

bors commented Mar 24, 2018

📌 Commit 36322d0 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
bors added a commit that referenced this pull request Mar 24, 2018
@bors bors merged commit 36322d0 into rust-lang:master Mar 24, 2018
@steveklabnik steveklabnik deleted the update-books branch March 25, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants