Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc support for universal_impl_trait #49304

Merged
merged 4 commits into from
Mar 28, 2018
Merged

Rustdoc support for universal_impl_trait #49304

merged 4 commits into from
Mar 28, 2018

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Mar 23, 2018 •
edited
Loading

Hides type parameters synthesized by impl Trait-in-argument-position, and enables links to trait names.

before

↓

after

Fixes #49309

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2018
@sinkuu
Copy link
Contributor Author

sinkuu commented Mar 23, 2018

Ah, no, this does not work if impl Debug is not the argument type directly, e.g. fn foo(x: (impl Debug, i32)).

@sinkuu sinkuu closed this Mar 23, 2018
@QuietMisdreavus
Copy link
Member

Ah, i was starting to read through it. Looking forward to seeing if you can get it working!

Also, it doesn't really require the other PR. It's okay to expose features in rustdoc that are unstable, because they'll only be there in the first place if the library enabled the feature. Other unstable features have been exposed in rustdoc before they were stable, and it's not like the other commits changed anything that rustdoc depends on.

@sinkuu sinkuu mentioned this pull request Mar 23, 2018
Closed
@sinkuu sinkuu reopened this Mar 24, 2018
@sinkuu sinkuu force-pushed the impl_trait_rustdoc branch from 7bc7fbe to 4800afa Compare March 24, 2018 05:19
@QuietMisdreavus
Copy link
Member

This looks great! Thanks so much!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 27, 2018

📌 Commit 4800afa has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2018
@kennytm
Copy link
Member

kennytm commented Mar 27, 2018

@bors p=6

@bors
Copy link
Contributor

bors commented Mar 28, 2018

⌛ Testing commit 4800afa with merge e58df0d...

bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of #49304 - sinkuu:impl_trait_rustdoc, r=QuietMisdreavus
e58df0d 
Rustdoc support for universal_impl_trait

Hides type parameters synthesized by `impl Trait`-in-argument-position, and enables links to trait names.

<img alt="before" src="https://user-images.githubusercontent.com/7091080/37831646-a61413c6-2ee9-11e8-8ec2-a6137956d922.png" width="450"/>
↓
<img alt="after" src="https://user-images.githubusercontent.com/7091080/37831657-b2ff0ae6-2ee9-11e8-8797-fdad904782bf.png" width="450"/>

Fixes #49309
@bors
Copy link
Contributor

bors commented Mar 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing e58df0d to master...

@bors bors merged commit 4800afa into rust-lang:master Mar 28, 2018
@QuietMisdreavus QuietMisdreavus mentioned this pull request May 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sinkuu @rust-highfive @QuietMisdreavus @bors @kennytm