Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a canonical trait query for evaluate_obligation #48995

Merged
merged 8 commits into from
Apr 27, 2018
Merged

Create a canonical trait query for evaluate_obligation #48995

merged 8 commits into from
Apr 27, 2018

Commits on Apr 27, 2018

  1. Refactor overflow handling in traits::select to propagate overflow in… 

    …stead of aborting eagerly

We store the obligation that caused the overflow as part of the OverflowError, and report it at the public API endpoints (rather than in the implementation internals).
    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    79f71f9 View commit details
    Browse the repository at this point in the history

  2. Create a canonical trait query for evaluate_obligation

    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    3ab3a9f View commit details
    Browse the repository at this point in the history

  3. Port existing callers of evaluate_obligation to the new canonical t… 

    …rait query

Except the one in coherence, which needs support for intercrate mode.
    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    bc16b8e View commit details
    Browse the repository at this point in the history

  4. Simplify trait selector's evaluation API slightly

    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    3dd26b8 View commit details
    Browse the repository at this point in the history

  5. Introduce trait query mode and use it to set overflow error handling … 

    …policy in traits::select
    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    e5535fc View commit details
    Browse the repository at this point in the history

  6. Remove the stored obligation in OverflowError to simplify things 

    We will shortly refactor things so that it is no longer needed
    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    5cb0372 View commit details
    Browse the repository at this point in the history

  7. Retry canonical trait query in standard mode if overflow occurs 

    This is slightly hacky and hopefully only a somewhat temporary solution.
    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    d5b2e90 View commit details
    Browse the repository at this point in the history

  8. Update a compile-fail test

    @aravind-pg
    aravind-pg committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    e423dcc View commit details
    Browse the repository at this point in the history