-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor away inferred_obligations
from the trait selector
#48710
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit 81f0b96 has been approved by |
Just for reference, @aravind-pg and I had a short conversation on gitter where I pointed out that this may change behavior slightly, but it seems like the existing behavior was a bug and I think in practice it wouldn't have any effect anyway. |
A small refactoring that removes the
inferred_obligations
field fromSelectionContext
in the trait selector in favor of threading nested obligations around explicitly. Closes #48672.r? @nikomatsakis