Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new warning for CStr::from_ptr #48507

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Add new warning for CStr::from_ptr #48507

merged 1 commit into from
Mar 6, 2018

Conversation

GuillaumeGomez
Copy link
Member

Fixes #48401.

r? @steveklabnik

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2018
@kennytm kennytm added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Feb 25, 2018
@shepmaster
Copy link
Member

Ping from triage, @steveklabnik !

@steveklabnik
Copy link
Member

I am not likely to be able to review until late tomorrow, possibly tuesday. Sorry about that!

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 6, 2018

📌 Commit 5344b07 has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018
@kennytm kennytm mentioned this pull request Mar 6, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48507 - GuillaumeGomez:cstr-note, r=stevekl…
75bc23d 
…abnik

Add new warning for CStr::from_ptr

Fixes rust-lang#48401.

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 6, 2018
@kennytm
Rollup merge of rust-lang#48507 - GuillaumeGomez:cstr-note, r=stevekl…
ebc6d6e 
…abnik

Add new warning for CStr::from_ptr

Fixes rust-lang#48401.
bors added a commit that referenced this pull request Mar 6, 2018
@bors
Auto merge of #48768 - kennytm:rollup, r=kennytm
2789b06 
Rollup of 14 pull requests

- Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463
- Failed merges:
@alexcrichton alexcrichton merged commit 5344b07 into rust-lang:master Mar 6, 2018
@GuillaumeGomez GuillaumeGomez deleted the cstr-note branch March 6, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@steveklabnik steveklabnik

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @shepmaster @steveklabnik @bors @alexcrichton @kennytm @rust-highfive