Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take 2^5 as examples in document of pow() #48397

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Take 2^5 as examples in document of pow() #48397

merged 1 commit into from
Feb 22, 2018

Conversation

ordovicia
Copy link
Contributor

Fixes #48396 by taking 2^5 as examples.

@ordovicia
Take 2^5 as examples in document of pow() (fixes rust-lang#48396)
7e51e7d 
Current document takes 2^4, which is equal to 4^2.
This example is not very helpful for those unfamiliar with math words in English and thus rely on example codes.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aidanhs (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2018
@kennytm kennytm added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Feb 21, 2018
@GuillaumeGomez
Copy link
Member

Well, ok. Fine by me.

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 21, 2018

📌 Commit 7e51e7d has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 21, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48397 - ordovicia:pow_doc, r=GuillaumeGomez
24c17cb 
Take 2^5 as examples in document of pow()

Fixes rust-lang#48396 by taking 2^5 as examples.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 21, 2018
Merged
bors added a commit that referenced this pull request Feb 22, 2018
@bors
Auto merge of #48399 - GuillaumeGomez:rollup, r=GuillaumeGomez
b1f8e6f 
Rollup of 12 pull requests

- Successful merges: #47379, #47833, #48106, #48198, #48314, #48325, #48335, #48352, #48354, #48360, #48382, #48397
- Failed merges:
@bors bors merged commit 7e51e7d into rust-lang:master Feb 22, 2018
@ordovicia ordovicia deleted the pow_doc branch February 22, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aidanhs aidanhs

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ordovicia @rust-highfive @GuillaumeGomez @bors @kennytm @aidanhs