Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nonstandard_style alias for bad_style. #48386

Merged
merged 4 commits into from
Feb 25, 2018
Merged

Add nonstandard_style alias for bad_style. #48386

merged 4 commits into from
Feb 25, 2018

Conversation

withoutboats
Copy link
Contributor

@withoutboats withoutboats commented Feb 20, 2018 •
edited
Loading

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@withoutboats
Copy link
Contributor Author

r? @Manishearth

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2018
@Manishearth
Copy link
Member

This isn't enough, right now the bad_style lint group will still be shown in the rustc -W help output.

What needs to be done is to rename the lint group and add a silent alias for backwards compatibility.

(also the interaction of overlapping lint groups is kinda iffy)

r=me for landing this as is though.

@withoutboats
Copy link
Contributor Author

Changed the comment to not close the tracking issue, this can be a good first step.

@Manishearth
Copy link
Member

@bors r+

A simple slightly-hacky way to do this would be to simply treat it as a different name when parsing lint group names.

@bors
Copy link
Contributor

bors commented Feb 20, 2018

📌 Commit 6fe5f42 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
sgrif
sgrif reviewed Feb 20, 2018
View reviewed changes
src/test/ui/lint/lint-group-nonstandard-style.rs Outdated
mod bad {
fn CamelCase() {} //~ ERROR should have a snake

static bad: isize = 1; //~ ERROR should have an upper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a downer.

@kennytm
Copy link
Member

kennytm commented Feb 21, 2018

@bors r=Manishearth

@bors
Copy link
Contributor

bors commented Feb 21, 2018

📌 Commit 5949d8b has been approved by Manishearth

@mark-i-m
Copy link
Member

Lol, why? I'm not sure I understand the motivation for this...

@steveklabnik
Copy link
Member

@mark-i-m #41646

@mark-i-m
Copy link
Member

Oh, it seems I missed quite an epic thread. It's good to know decisions like that are not made lightly, even though I don't fully agree with the change :)

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2018
@Manishearth
Rollup merge of rust-lang#48386 - withoutboats:nonstandard-style, r=M…
d45c4a6 
…anishearth

Add nonstandard_style alias for bad_style.
@Manishearth Manishearth mentioned this pull request Feb 24, 2018
Merged
bors added a commit that referenced this pull request Feb 25, 2018
@bors
Auto merge of #48520 - Manishearth:rollup, r=Manishearth
026339e 
Rollup of 15 pull requests

- Successful merges: #47689, #48110, #48197, #48296, #48386, #48392, #48404, #48415, #48441, #48448, #48452, #48481, #48490, #48499, #48503
- Failed merges:
@bors bors merged commit 5949d8b into rust-lang:master Feb 25, 2018
@Manishearth Manishearth mentioned this pull request Aug 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgrif sgrif sgrif left review comments

Assignees

@Manishearth Manishearth

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@withoutboats @rust-highfive @Manishearth @bors @kennytm @mark-i-m @steveklabnik @sgrif @nikomatsakis