Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 17 pull requests #48104

Closed
wants to merge 37 commits into from
Closed

Rollup of 17 pull requests #48104

wants to merge 37 commits into from

Commits on Jan 26, 2018

  1. derive PartialEq and Eq for ParseCharError

    unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
    tinaun committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    838ddbf View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2018

  1. Configuration menu
    Copy the full SHA
    505ef7b View commit details
    Browse the repository at this point in the history
  2. Remove VecCell

    Mark-Simulacrum committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    caa42e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. Create a directory for --out-dir if it does not already exist

    Currently if `--out-dir` is set to a non-existent directory, the
    compiler will throw unfriendly messages like `error: could not write
    output to subdir/example.crate.allocator.rcgu.o: No such file or
    directory`, which, while not completely unreadable, isn’t very
    user-friendly either. This change creates the directory automatically
    if it does not yet exist.
    varkor committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    79d85da View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Configuration menu
    Copy the full SHA
    7be8e2f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. Fix ICE for mismatched args on target without span

    Commit 7ed00ca improved our error reporting by including the target
    function in our error messages when there is an argument count mismatch.
    A simple example from the UI tests is:
    
    ```
    error[E0593]: function is expected to take a single 2-tuple as argument, but it takes 0 arguments
      --> $DIR/closure-arg-count.rs:32:53
       |
    32 |     let _it = vec![1, 2, 3].into_iter().enumerate().map(foo);
       |                                                     ^^^ expected function that takes a single 2-tuple as argument
    ...
    44 | fn foo() {}
       | -------- takes 0 arguments
    ```
    
    However, this assumed the target span was always available. This does
    not hold true if the target function is in `std` or another crate. A
    simple example from rust-lang#48046 is assigning `str::split` to a function type
    with a different number of arguments.
    
    Fix by removing all of the labels and suggestions related to the target
    span when it's not found.
    
    Fixes rust-lang#48046
    etaoins committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    daaa9a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    528d6b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    78a0b7f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37b5af2 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. Configuration menu
    Copy the full SHA
    04fde1c View commit details
    Browse the repository at this point in the history
  2. Add rustc_args_required_const to the feature whitelist

    Unfortunately left out it means that when the `#![feature(proc_macro)]` flag is
    in effect it fails to find `rustc_args_required_const` for expansion. This
    version, however, is verified to work with stdsimd's requirements!
    alexcrichton committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    35dca7e View commit details
    Browse the repository at this point in the history
  3. Disallow function pointers to #[rustc_args_required_const]

    This commit disallows acquiring a function pointer to functions tagged as
    `#[rustc_args_required_const]`. This is intended to be used as future-proofing
    for the stdsimd crate to avoid taking a function pointer to any intrinsic which
    has a hard requirement that one of the arguments is a constant value.
    alexcrichton committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    7a20fc1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e9bcb4e View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2018

  1. rustbuild: Pass ccache to build scripts

    Right now the ccache setting is only used for LLVM, but this tweaks it to also
    be used for build scripts so C++ builds like `librustc_llvm` can be a bit
    speedier.
    alexcrichton committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    64a8730 View commit details
    Browse the repository at this point in the history
  2. Update the dlmalloc submodule

    A bug was recently fixed in dlmalloc which meant that released memory to the
    system accidentally wasn't getting reused, causing programs to be far slower
    than they should be!
    alexcrichton committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    bb0df96 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    774997d View commit details
    Browse the repository at this point in the history
  4. Forcibly disable optimizations in backtrace-debuginfo

    Various versions of LLVM do various things with debuginfo but we're most curious
    that our own code is working so let's just disable optimizations in this test to
    ensure we have as much pristine debuginfo as possible.
    alexcrichton committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    b521c77 View commit details
    Browse the repository at this point in the history
  5. Don't cross-compile Emscripten's LLVM

    Eventually the LLVM version of Emscripten and the main LLVM will diverge, and we
    can't cross-compile an older version of LLVM using a newer version of LLVM's
    `llvm-config`.
    alexcrichton committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    866d13a View commit details
    Browse the repository at this point in the history
  6. ci: Actually bootstrap on i686 dist

    Right now the `--build` option was accidentally omitted, so we're bootstraping
    from `x86_64` to `i686`. In addition to being slower (more compiles) that's not
    actually bootstrapping!
    alexcrichton committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    9c05bab View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fe8e0d9 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#47790 - tinaun:patch-1, r=sfackler

    derive PartialEq and Eq for `ParseCharError`
    
    unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    270e6aa View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#47835 - Mark-Simulacrum:remove-data-structs…

    …, r=nikomatsakis
    
    Remove unused data structures
    
    Cleanup; as far as I can tell the compiler no longer uses these.
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    df1c16c View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#47854 - varkor:create-out-dir, r=pnkfelix

    Create a directory for --out-dir if it does not already exist
    
    Currently if `--out-dir` is set to a non-existent directory, the compiler will throw unfriendly messages like `error: could not write output to subdir/example.crate.allocator.rcgu.o: No such file or
    directory`, which, while not completely unreadable, isn’t very user-friendly either. This change creates the directory automatically if it does not yet exist.
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    7c17ac8 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#48015 - o01eg:disableable-installation, r=a…

    …lexcrichton
    
    Customizable extended tools
    
    This PR adds `build.tools` option to manage installation of extended rust tools.
    
    By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation.
    
    If some set of tools chosen only those tools are built and installed without any fails allowed.
    
    It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    ebbc35b View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#48047 - etaoins:fix-ice-for-mismatched-args…

    …-on-target-without-span, r=estebank
    
    Fix ICE for mismatched args on target without span
    
    Commit 7ed00ca improved our error reporting by including the target function in our error messages when there is an argument count mismatch. A simple example from the UI tests is:
    
    ```
    error[E0593]: function is expected to take a single 2-tuple as argument, but it takes 0 arguments
      --> $DIR/closure-arg-count.rs:32:53
       |
    32 |     let _it = vec![1, 2, 3].into_iter().enumerate().map(foo);
       |                                                     ^^^ expected function that takes a single 2-tuple as argument
    ...
    44 | fn foo() {}
       | -------- takes 0 arguments
    ```
    
    However, this assumed the target span was always available. This does not hold true if the target function is in `std` or another crate. A simple example from rust-lang#48046 is assigning `str::split` to a function type with a different number of arguments.
    
    Fix by omitting all of the labels and suggestions related to the target span when it's not found.
    
    Fixes rust-lang#48046
    
    r? @estebank
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    67d4800 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#48051 - ollie27:rustdoc_fn_unit_return, r=Q…

    …uietMisdreavus
    
    rustdoc: Hide `-> ()` in cross crate inlined Fn* bounds
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    f3ee01e View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#48058 - cuviper:binaryen-gcc8, r=alexcrichton

    Update binaryen to fix -Werror with GCC 8
    
    r? @alexcrichton
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    b7f8fa6 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#48059 - alexcrichton:sccachebs, r=Mark-Simu…

    …lacrum
    
    rustbuild: Pass `ccache` to build scripts
    
    Right now the ccache setting is only used for LLVM, but this tweaks it to also
    be used for build scripts so C++ builds like `librustc_llvm` can be a bit
    speedier.
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    b182bf1 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#48064 - Manishearth:intra-doc-bail, r=Quiet…

    …Misdreavus
    
    intra-doc-links: bail early for linky things
    
    r? @QuietMisdreavus
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    ec01b28 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#48078 - alexcrichton:fix-required-const-and…

    …-proc-macro, r=eddyb
    
    Disallow function pointers to #[rustc_args_required_const]
    
    This commit disallows acquiring a function pointer to functions tagged as
    `#[rustc_args_required_const]`. This is intended to be used as future-proofing
    for the stdsimd crate to avoid taking a function pointer to any intrinsic which
    has a hard requirement that one of the arguments is a constant value.
    
    Note that the first commit here isn't related specifically to this feature, but was necessary to get this working in stdsimd!
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    6747b17 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#48080 - GuillaumeGomez:mobile-docs-fixes, r…

    …=QuietMisdreavus
    
    Hide theme button under menu in mobile mode and fix top margin issue …
    
    Fixes rust-lang#48060.
    
    r? @QuietMisdreavus
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    cbc3b8c View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#48085 - alexcrichton:update-dlmalloc, r=Mar…

    …k-Simulacrum
    
    Update the dlmalloc submodule
    
    A bug was recently fixed in dlmalloc which meant that released memory to the
    system accidentally wasn't getting reused, causing programs to be far slower
    than they should be!
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    1ef535e View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#48086 - Zoxc:gen-fix, r=nikomatsakis

    Fix visitation order of calls so that it matches execution order. Fixes rust-lang#48048
    
    r? @nikomatsakis
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    4ed1ba6 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#48090 - alexcrichton:disable-opt-test, r=ni…

    …komatsakis
    
    Forcibly disable optimizations in backtrace-debuginfo
    
    Various versions of LLVM do various things with debuginfo but we're most curious
    that our own code is working so let's just disable optimizations in this test to
    ensure we have as much pristine debuginfo as possible.
    
    This is currently extracted from rust-lang#47828 to land standalone
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    671206b View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#48093 - alexcrichton:dont-cross-emscripten,…

    … r=Mark-Simulacrum
    
    Don't cross-compile Emscripten's LLVM
    
    Eventually the LLVM version of Emscripten and the main LLVM will diverge, and we
    can't cross-compile an older version of LLVM using a newer version of LLVM's
    `llvm-config`.
    
    This is extracted from rust-lang#47828
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    e471747 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#48098 - alexcrichton:fix-i686-dist-bootstra…

    …p, r=Mark-Simulacrum
    
    ci: Actually bootstrap on i686 dist
    
    Right now the `--build` option was accidentally omitted, so we're bootstraping
    from `x86_64` to `i686`. In addition to being slower (more compiles) that's not
    actually bootstrapping!
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    258be62 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#48101 - Mark-Simulacrum:new-books, r=stevek…

    …labnik Update books for next release
    kennytm committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    878e701 View commit details
    Browse the repository at this point in the history