Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Fix link title rendering with hoedown #47855

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jan 29, 2018

The link title needs to be HTML escaped.

It was broken by #47046.

r? @QuietMisdreavus

@killercup
Copy link
Member

LGTM but could use a test

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 29, 2018
@ollie27
Copy link
Member Author

ollie27 commented Jan 29, 2018

added test

@QuietMisdreavus
Copy link
Member

As-is, the test just makes sure that the link doesn't change between the renderers. Once we take Hoedown out, that test will not do anything (and will actually fail because we'll probably take that flag out at the same time). Can you add a @has directive to the test to make sure the link is what we expect?

The link title needs to be HTML escaped.
@ollie27
Copy link
Member Author

ollie27 commented Jan 29, 2018

I've updated the test to use @has but the test still won't be very useful when hoedown is removed.

@QuietMisdreavus
Copy link
Member

Ah, i missed where the change was happening in. In any case, we can keep this around to make sure we (or Pulldown?) don't mess this up in the future.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 29, 2018

📌 Commit ae98f4c has been approved by QuietMisdreavus

kennytm added a commit to kennytm/rust that referenced this pull request Jan 30, 2018
… r=QuietMisdreavus

rustdoc: Fix link title rendering with hoedown

The link title needs to be HTML escaped.

It was broken by rust-lang#47046.

r? @QuietMisdreavus
bors added a commit that referenced this pull request Jan 30, 2018
Rollup of 12 pull requests

- Successful merges: #47515, #47603, #47718, #47732, #47760, #47780, #47822, #47826, #47836, #47839, #47853, #47855
- Failed merges:
@bors bors merged commit ae98f4c into rust-lang:master Jan 30, 2018
@ollie27 ollie27 deleted the rustdoc_hoedown_link_title branch January 30, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants