Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized error reporting for recursive requirements #47720 #47804

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Optimized error reporting for recursive requirements #47720 #47804

merged 1 commit into from
Feb 13, 2018

Conversation

hrvolapeter
Copy link
Member

Fixes #47720

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm
Copy link
Member

kennytm commented Jan 31, 2018

Thanks for the PR! We’ll periodically check in on it to make sure that @pnkfelix or someone else from the team reviews it soon.

@kennytm kennytm added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2018
@pietroalbini
Copy link
Member

@pnkfelix ping from triage! This PR needs a review.

@pnkfelix
Copy link
Member

pnkfelix commented Feb 8, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Feb 8, 2018

📌 Commit 80b8c80 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2018
@bors
Copy link
Contributor

bors commented Feb 8, 2018

⌛ Testing commit 80b8c80 with merge d8e19e5c3b2495f91fe7bccdbbab24137f1ddf2e...

@bors
Copy link
Contributor

bors commented Feb 8, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2018
@kennytm
Copy link
Member

kennytm commented Feb 8, 2018 •
edited
Loading

@bors retry

3 hour timeout in asmjs.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2018
@bors
Copy link
Contributor

bors commented Feb 9, 2018

⌛ Testing commit 80b8c80 with merge 8105b248e3ff50ae2fe33ccdce3c4456cfb5303b...

@hrvolapeter
Copy link
Member Author

@kennytm I think this got stuck

@kennytm
Copy link
Member

kennytm commented Feb 11, 2018

@retep007 No the queue is normal. This PR was taken out to give way to more important ones (and the CI situation is not particularly healthy recently). Sorry for the delay.

@bors
Copy link
Contributor

bors commented Feb 11, 2018

⌛ Testing commit 80b8c80 with merge 284c74c6e941f238e301d9ae52e457cbe3c8c1b3...

@bors
Copy link
Contributor

bors commented Feb 12, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2018
@pietroalbini
Copy link
Member

Known failure: #48116

[01:55:52] failures:
[01:55:52]     [compile-fail] compile-fail/rfc-2126-extern-in-paths/single-segment.rs
[01:55:52]     [compile-fail] compile-fail/use-keyword.rs
[01:55:52]     [compile-fail] compile-fail/use-mod-2.rs

@kennytm kennytm mentioned this pull request Feb 12, 2018
Closed
@kennytm
Copy link
Member

kennytm commented Feb 12, 2018

@bors retry #48116

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2018
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 80b8c80 with merge 109626573a4aab2abd698459d65e9c3eef4f1de1...

@bors
Copy link
Contributor

bors commented Feb 12, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2018
@kennytm
Copy link
Member

kennytm commented Feb 12, 2018

@bors retry #48116

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2018
@bors
Copy link
Contributor

bors commented Feb 13, 2018

⌛ Testing commit 80b8c80 with merge 4d2d3fc...

bors added a commit that referenced this pull request Feb 13, 2018
@bors
Auto merge of #47804 - retep007:recursive-requirements, r=pnkfelix
4d2d3fc 
Optimized error reporting for recursive requirements #47720

Fixes #47720
@bors
Copy link
Contributor

bors commented Feb 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 4d2d3fc to master...

@bors bors merged commit 80b8c80 into rust-lang:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hrvolapeter @rust-highfive @kennytm @pietroalbini @pnkfelix @bors