Map invalid Spans to DUMMY_SP during crate metadata encoding. #47177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors what we for stabilizing the incr. comp. cache and is necessary for reproducible builds.
kennytm
added
the
S-waiting-on-review
petrochenkov
reviewed
Jan 4, 2018
src/librustc_metadata/encoder.rs
Outdated
|
|
||
| let span = span.data(); | ||
|
|
||
| if span.lo > span.hi { |
There was a problem hiding this comment.
As I mentioned in #47066 (comment), this should not be possible when you use Span.
Span uses encoding lo + len, similarly to metadata, so it can't represent spans with lo > hi.
|
Thanks, @petrochenkov, I replaced the |
|
@bors: r+ Looks great! |
|
📌 Commit 30d921f has been approved by |
alexcrichton
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 7, 2018
…tadata-encoding, r=alexcrichton Map invalid Spans to DUMMY_SP during crate metadata encoding. This mirrors what we do for stabilizing the incr. comp. cache and is necessary for reproducible builds. For the incr. comp. cache, we *have* to do this because the encoding there cannot represent broken Spans. Metadata encoding has to be in sync with that as not to get unexpected interactions when compiling incrementally. This should help with fixing issue #47066. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors what we do for stabilizing the incr. comp. cache and is necessary for reproducible builds. For the incr. comp. cache, we have to do this because the encoding there cannot represent broken Spans. Metadata encoding has to be in sync with that as not to get unexpected interactions when compiling incrementally.
This should help with fixing issue #47066.
r? @alexcrichton