rustc: Set release mode cgus to 16 by default #46910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ Let's try it. We can easily revert before the next release if there's a major problem. |
|
📌 Commit 24834eb has been approved by |
kennytm
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
…haelwoerister rustc: Set release mode cgus to 16 by default This commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closes rust-lang#45320
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 23, 2017
…haelwoerister rustc: Set release mode cgus to 16 by default This commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closes rust-lang#45320
alexcrichton
force-pushed
the
thinlto-default
branch
from
3230850
to
8e25bf3
Compare
|
I've opened an LLVM bug for that failure. |
alexcrichton
force-pushed
the
thinlto-default
branch
from
8e25bf3
to
93e5fac
Compare
This commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closes rust-lang#45320
alexcrichton
force-pushed
the
thinlto-default
branch
from
93e5fac
to
b5361d0
Compare
|
@bors: r=michaelwoerister |
|
📌 Commit b5361d0 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 25, 2017
rustc: Set release mode cgus to 16 by default This commit is the next attempt to enable multiple codegen units by default in release mode, getting some of those sweet, sweet parallelism wins by running codegen in parallel. Performance should not be lost due to ThinLTO being on by default as well. Closes #45320
|
☀️ Test successful - status-appveyor, status-travis |
bluss
added
the
relnotes
|
Probably because of this I am seeing nearly halved compilation times. (But I am seeing a problem I'll file soon, I don't know if it's the same LLVM failure reported above. Edit: it's #47015 ). |
Merged
This was referenced Jan 11, 2018
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the next attempt to enable multiple codegen units by default in
release mode, getting some of those sweet, sweet parallelism wins by running
codegen in parallel. Performance should not be lost due to ThinLTO being on by
default as well.
Closes #45320