Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aarch64-unknown-openbsd support #46760

Merged
merged 1 commit into from
Dec 20, 2017
Merged

add aarch64-unknown-openbsd support #46760

merged 1 commit into from
Dec 20, 2017

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Dec 16, 2017

  • make liblibc to point to libc with aarch64-unknown-openbsd
  • make c_char (in std::os::raw) to point to right value

r? @alexcrichton

currently, I have only tested in crosscompilation environement (openbsd x64_64 -> openbsd aarch64). it produces valid binaries.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 16, 2017

📌 Commit 6b184b0 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 16, 2017

⌛ Testing commit 6b184b09ce1c186e5a2ed610f21d5f44dd5ec43b with merge 3a97ba4b02384b183ab370e50338f943fc7124b0...

@bors
Copy link
Contributor

bors commented Dec 16, 2017

💔 Test failed - status-travis

@semarie
Copy link
Contributor Author

semarie commented Dec 17, 2017

errors are due to libc code for freebsd:

[00:34:48] error: `#[deprecated]` cannot be used in staged api, use `#[rustc_deprecated]` instead
[00:34:48]    --> /checkout/src/rustc/libc_shim/../../liblibc/src/unix/bsd/freebsdlike/freebsd/mod.rs:453:1
[00:34:48]     |
[00:34:48] 453 | pub const IFF_DRV_RUNNING: ::c_int = 0x40;
[00:34:48]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:34:48]
[00:34:48] error: `#[deprecated]` cannot be used in staged api, use `#[rustc_deprecated]` instead
[00:34:48]    --> /checkout/src/rustc/libc_shim/../../liblibc/src/unix/bsd/freebsdlike/freebsd/mod.rs:460:1
[00:34:48]     |
[00:34:48] 460 | pub const IFF_DRV_OACTIVE: ::c_int = 0x400;
[00:34:48]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:34:48]

it contains code that seems to be not usable in staged api:

#[deprecated(since="0.2.34",
             note="please use the portable `IFF_RUNNING` constant instead")]
pub const IFF_DRV_RUNNING: ::c_int = 0x40;

@alexcrichton what should be the correct way to deal with that ? I assume it should be corrected in libc ? but how ?

@semarie semarie mentioned this pull request Dec 17, 2017
Merged
@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 17, 2017
@asomers
Copy link
Contributor

asomers commented Dec 17, 2017

Is the problem that rust-lang is using those deprecated constants, or reexporting them?

@semarie
Copy link
Contributor Author

semarie commented Dec 17, 2017

@asomers I found no usage of this constants neither explicit reexport.

@alexcrichton
Copy link
Member

@semarie want to send a PR to libc to remove those attributes?

@semarie semarie mentioned this pull request Dec 17, 2017
Closed
@semarie
add aarch64-unknown-openbsd support
8c7b093 
- make liblibc to point to libc with aarch64-unknown-openbsd
- make c_char (in std::os::raw) to point to right value
@semarie
Copy link
Contributor Author

semarie commented Dec 18, 2017

ok, I updated my branch to include the deprecated removing

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 18, 2017

📌 Commit 8c7b093 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017
@kennytm
Rollup merge of rust-lang#46760 - semarie:openbsd-arm64, r=alexcrichton
1d57459 
add aarch64-unknown-openbsd support

- make liblibc to point to libc with aarch64-unknown-openbsd
- make c_char (in std::os::raw) to point to right value

r? @alexcrichton

currently, I have only tested in crosscompilation environement (openbsd x64_64 -> openbsd aarch64). it produces valid binaries.
@kennytm kennytm mentioned this pull request Dec 20, 2017
Merged
bors added a commit that referenced this pull request Dec 20, 2017
@bors
Auto merge of #46874 - kennytm:rollup, r=kennytm
81622c6 
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:
@bors bors merged commit 8c7b093 into rust-lang:master Dec 20, 2017
@semarie semarie deleted the openbsd-arm64 branch March 25, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@semarie @alexcrichton @bors @asomers @kennytm