Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention nightly in -Z external-macro-backtrace note #46168

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

durka
Copy link
Contributor

@durka durka commented Nov 21, 2017

Fix #46167 by mentioning that you need nightly in the message that tells you to pass -Z external-macro-backtrace.

Rationale:

  1. The reason for having this message is to increase discoverability of the functionality. If the message is only shown on nightly it's less disoverable.
  2. The same approach is taken if you call a const fn in const context without its feature gate (previously, if you called it without #![feature(const_fn)]).

cc @kennytm

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2017
@petrochenkov
Copy link
Contributor

I buy the rationale.
@bors r+

If you disagree, please r- and assign yourself as the reviewer.

@bors
Copy link
Contributor

bors commented Nov 23, 2017

📌 Commit 95de1a2 has been approved by petrochenkov

@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2017
@bors
Copy link
Contributor

bors commented Nov 25, 2017

⌛ Testing commit 95de1a20664a2fb708dc7557993efc4232b4c3c9 with merge d80dce2a8acab980568114a0d5eeb45992c36abb...

@bors
Copy link
Contributor

bors commented Nov 25, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Nov 25, 2017

One missing change in issue-44953.rs in a ui-fulldeps test.

 error: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead? (see issue #27812)
   --> $DIR/issue-44953.rs:16:14
    |
 16 | #[macro_use] extern crate log; //~ ERROR use of unstable library feature
    |              ^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
 
 error: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead? (see issue #27812)
   --> $DIR/issue-44953.rs:19:5
    |
 19 |     info!("This is a log message.");
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable
-   = note: this error originates in a macro outside of the current crate (run with -Z external-macro-backtrace for more info)
+   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

@bors p=1 — Anticipating fragility.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2017
@petrochenkov
Copy link
Contributor

@bors delegate+

@bors
Copy link
Contributor

bors commented Nov 26, 2017

✌️ @durka can now approve this pull request

@durka
Copy link
Contributor Author

durka commented Nov 26, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 26, 2017

📌 Commit 5da957c has been approved by durka

@bors
Copy link
Contributor

bors commented Nov 26, 2017

⌛ Testing commit 5da957c with merge 9015b14...

bors added a commit that referenced this pull request Nov 26, 2017
mention nightly in -Z external-macro-backtrace note

Fix #46167 by mentioning that you need nightly in the message that tells you to pass `-Z external-macro-backtrace`.

Rationale:

1. The reason for having this message is to increase discoverability of the functionality. If the message is only shown on nightly it's less disoverable.
2. The same approach is taken if you call a const fn in const context without its feature gate (previously, if you called it without `#![feature(const_fn)]`).

cc @kennytm
@bors
Copy link
Contributor

bors commented Nov 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: durka
Pushing 9015b14 to master...

@bors bors merged commit 5da957c into rust-lang:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants